This repository was archived by the owner on Nov 20, 2024. It is now read-only.
@IncompatibleWith #1909
Merged
@IncompatibleWith #1909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Dec 26, 2019
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// Linter metadata annotations. |
There was a problem hiding this comment.
nit: You need a directive in order to differentiate between library docs and docs on a member.
There was a problem hiding this comment.
Yes. I suppose this is dangling. (Call for another warning perhaps? 🤔)
I thought I recalled library directives falling out of favor... Besides cooking up a library name, is there another preferred convention?
There was a problem hiding this comment.
I thought I recalled library directives falling out of favor ...
They are. Any directive will do, but in a library like this one that doesn't need any directives I don't know what else to do. It seems silly to add a import 'dart:core'; to avoid adding a library directive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bike-shedding for dart-lang/sdk#58088.
/cc @bwilkerson