Skip to content

[Core] Use canonical path in tests #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[Core] Use canonical path in tests #2253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/test/java/io/cucumber/core/plugin/PluginFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void creates_parent_directories() {
}

@Test
void cant_create_plugin_when_parent_directory_is_a_file() {
void cant_create_plugin_when_parent_directory_is_a_file() throws IOException {
Path htmlReport = tmp.resolve("target/cucumber/reports");
PluginOption htmlOption = parse("html:" + htmlReport);
plugin = fc.create(htmlOption);
Expand All @@ -101,8 +101,8 @@ void cant_create_plugin_when_parent_directory_is_a_file() {

IllegalArgumentException exception = assertThrows(IllegalArgumentException.class, () -> fc.create(jsonOption));
assertThat(exception.getMessage(), is(equalTo(
"Couldn't create parent directories of '" + jsonReport + "'.\n" +
"Make sure the the parent directory '" + jsonReport.getParent() + "' isn't a file.\n" +
"Couldn't create parent directories of '" + jsonReport.toFile().getCanonicalPath() + "'.\n" +
"Make sure the the parent directory '" + jsonReport.getParent().toFile().getCanonicalPath() + "' isn't a file.\n" +
"\n" +
"Note: This usually happens when plugins write to colliding paths.\n" +
"For example: 'html:target/cucumber, json:target/cucumber/report.json'\n" +
Expand Down