Skip to content

Conversation

stepio
Copy link
Contributor

@stepio stepio commented Mar 4, 2021

Is your pull request related to a problem? Please describe.

#2252

Describe the solution you have implemented
Used getCanonicalPath() in test as it's used in the tested class

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #2253 (3fba5fc) into main (fabe829) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2253   +/-   ##
=========================================
  Coverage     83.01%   83.01%           
  Complexity     2340     2340           
=========================================
  Files           307      307           
  Lines          8324     8324           
  Branches        768      768           
=========================================
  Hits           6910     6910           
  Misses         1110     1110           
  Partials        304      304           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fabe829...160739f. Read the comment docs.

@mpkorstanje mpkorstanje changed the title GH-2252 Get canonical path for test data [Core] Use canonical path in tests Mar 4, 2021
@mpkorstanje mpkorstanje merged commit dde1d4c into cucumber:main Mar 4, 2021
@aslakhellesoy
Copy link
Contributor

Hi @stepio,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@stepio stepio deleted the bugfix/GH-2252 branch March 4, 2021 08:37
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants