Implementing highlight UI (part 1) #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use different Bundle ID (#12) * Testflight version 1 from main (#13) * Use different Bundle ID * Add ci_scripts and remove codegen file * Add ci_scripts and Display Name * Fix secrets ci_script issue * Made script executable * Made AppIcon square * Ensure AppIcon has no transparency * Release 1.0.0 Build 17 (#19) * Merge release into Main (#15) * Use different Bundle ID (#12) * Testflight version 1 from main (#13) * Use different Bundle ID * Add ci_scripts and remove codegen file * Add ci_scripts and Display Name * Fix secrets ci_script issue * Made script executable * Made AppIcon square * Ensure AppIcon has no transparency * Added scrollview to opponent name (#10) * added String extension file with a function to remove prefix for university of. Applied it to opponent names in game cards * added comment to new string function * reverse shorten University name, instead made it scrollable * added scroll view to more views * Delete Package.resolved * made new textUtil file for string manipulation specifically for university name being too long, made it scrollable, added shadow to trailing to indicate scrollable. Shorten university of to U * added comment to TextUtil.trailingFadeWhite * PR Comment Fixed - made new folder for ViewModifier and moved TrailingFadeGradient to withTrailingFadeGradient - renamed TextUtil file to String+Extention --------- * Adelynnwu/fix background bugs (#18) * added ci_scripts and modified codegen * refactor duplicated code in GameView, DynamicScoreBox, etc and implemented PastGameViewModel * fixed game tile text color * fixed game summary background and carousel card corner radius * Some bug fixes * fixed score box and game location display issue * Prepare for testing attempt 1 * Fix merge bugs and set App Category & build * Fix loading state bug --------- --------- * fixed incosistenc score breakdowns and removed ice hockey (#23) (#24) * fixed incosistenc score breakdowns and removed ice hockey * Remove tracking of GameAPI and change to fragments * Remove default to prevent error * Implement Temp Fix for pagination and add load more button --------- * Release 1.0.0 Build 23 (#25) * fixed incosistenc score breakdowns and removed ice hockey (#23) * fixed incosistenc score breakdowns and removed ice hockey * Remove tracking of GameAPI and change to fragments * Remove default to prevent error * Implement Temp Fix for pagination and add load more button --------- * Increment marketing version --------- * Release Version 1.0.2 Build 26 (#28) * fixed incosistenc score breakdowns and removed ice hockey (#23) * fixed incosistenc score breakdowns and removed ice hockey * Remove tracking of GameAPI and change to fragments * Remove default to prevent error * Implement Temp Fix for pagination and add load more button --------- * Increment marketing version * fix upcoming card icon (#27) * Updated Build and version --------- * Release 1.0.3 Build 27 (#32) * fixed incosistenc score breakdowns and removed ice hockey (#23) * fixed incosistenc score breakdowns and removed ice hockey * Remove tracking of GameAPI and change to fragments * Remove default to prevent error * Implement Temp Fix for pagination and add load more button --------- * Increment marketing version * fix upcoming card icon (#27) * Updated README and added set-up instructions (#30) * Set up Firebase Analytics (#29) * Set up Firebase * Removed previous TODO * Resolved merge conflicts --------- * Create Package.resolved * Release 1.0.3 Build 29 * Release 1.0.3 Build 30 --------- Co-authored-by: Angelina Chen <[email protected]> Co-authored-by: Jayson Hahn <[email protected]> Co-authored-by: Jayson Hahn <[email protected]> Co-authored-by: Jay Z. <[email protected]> Co-authored-by: AdelynnWu <[email protected]> Co-authored-by: Richie Sun <[email protected]> Co-authored-by: Peter Bidoshi <[email protected]> Co-authored-by: Peter <[email protected]>
MrPeterss
requested changes
Oct 16, 2025
Contributor
MrPeterss
left a comment
MrPeterss
left a comment
There was a problem hiding this comment.
Really nice work, Zain! I'm surprised I don't have more comments on this one because its so large. Once you address the comments, go ahead and request me again!
score-ios/Resources/Assets.xcassets/Highlight-selected.imageset/Contents.json
Show resolved
Hide resolved
angelinaa-chen
approved these changes
Oct 16, 2025
Contributor
angelinaa-chen
left a comment
angelinaa-chen
left a comment
There was a problem hiding this comment.
YAY congrats on your first (and large) PR Zain! This is super impressive, the overall code structure is amazing and I'm so so excited for this feature. I only had a couple of comments to make, but once you address Peter's styling comments as well you should be good to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented most of Highlight UI:
Highlight.swift,YoutubeVideo.swift,Article.swiftto represent the types of data I'll be showing. Highlight is a parent datatype that can be a YoutubeVideo or Article to write less codeHighlightTile.swift,HighlightTileVideo.swift,HighlightTileArticle.swift, which represent the tiles for Highlight videos/articles. HighlightTile acts as a parent view for easier data passing regardless of type. (currently three different files, but can be put into one for ease)HighlightView.swiftandDetailedHighlightView.swift, representing the two possible view lists for highlights (horizontal, vertical)SearchView.swiftandSearchViewFullScreen.swift. SearchView represents the clickable search bar that opens the search modal. SearchViewFullScreen represents the search modal, where the user can actually search. SearchViewFullScreen is in MainViews, it has debouncing logic to not update excessively, and it uses aDispatchWorkItem.NoHighlightView.swiftto show as a screen for when there are no results in the search (needs a higher resolution icon)Dates.swift,isWithinPastDaysto check if a date falls within a given number of days.View+CornerRadius.swiftto enable rounding specific corners of a view.TODO: