Skip to content

Conversation

@angelinaa-chen
Copy link
Contributor

No description provided.

Copy link
Contributor

@AdelynnWu AdelynnWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@MrPeterss MrPeterss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Make sure to address the 2 short comments before merging

@angelinaa-chen angelinaa-chen merged commit 2f09bbd into main Sep 17, 2025
@angelinaa-chen angelinaa-chen deleted the Angelina/Firebase branch September 17, 2025 19:20
MrPeterss added a commit that referenced this pull request Oct 1, 2025
* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------

Co-authored-by: Jayson Hahn <[email protected]>

* Increment marketing version

* fix upcoming card icon (#27)

* Updated README and added set-up instructions (#30)

* Set up Firebase Analytics (#29)

* Set up Firebase

* Removed previous TODO

* Resolved merge conflicts

---------

Co-authored-by: AdelynnWu <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Angelina Chen <[email protected]>
Co-authored-by: Angelina Chen <[email protected]>
angelinaa-chen added a commit that referenced this pull request Oct 2, 2025
* Set up Firebase

* Removed previous TODO
angelinaa-chen added a commit that referenced this pull request Oct 2, 2025
* Set up Firebase

* Removed previous TODO
angelinaa-chen added a commit that referenced this pull request Oct 2, 2025
* Use different Bundle ID (#12)

* Testflight version 1 from main (#13)

* Use different Bundle ID

* Add ci_scripts and remove codegen file

* Add ci_scripts and Display Name

* Fix secrets ci_script issue

* Made script executable

* Made AppIcon square

* Ensure AppIcon has no transparency

* Release 1.0.0 Build 17 (#19)

* Merge release into Main (#15)

* Use different Bundle ID (#12)

* Testflight version 1 from main (#13)

* Use different Bundle ID

* Add ci_scripts and remove codegen file

* Add ci_scripts and Display Name

* Fix secrets ci_script issue

* Made script executable

* Made AppIcon square

* Ensure AppIcon has no transparency

* Added scrollview to opponent name (#10)

* added String extension file with a function to remove prefix for university of. Applied it to opponent names in game cards

* added comment to new string function

* reverse shorten University name, instead made it scrollable

* added scroll view to more views

* Delete Package.resolved

* made new textUtil file for string manipulation specifically for university name being too long, made it scrollable, added shadow to trailing to indicate scrollable. Shorten university of to U

* added comment to TextUtil.trailingFadeWhite

* PR Comment Fixed

- made new folder for ViewModifier and moved TrailingFadeGradient to withTrailingFadeGradient
- renamed TextUtil file to String+Extention

---------

Co-authored-by: Jayson Hahn <[email protected]>

* Adelynnwu/fix background bugs (#18)

* added ci_scripts and modified codegen

* refactor duplicated code in GameView, DynamicScoreBox, etc and implemented PastGameViewModel

* fixed game tile text color

* fixed game summary background and carousel card corner radius

* Some bug fixes

* fixed score box and game location display issue

* Prepare for testing attempt 1

* Fix merge bugs and set App Category & build

* Fix loading state bug

---------

Co-authored-by: Jayson Hahn <[email protected]>

---------

Co-authored-by: Jay Z. <[email protected]>
Co-authored-by: AdelynnWu <[email protected]>

* fixed incosistenc score breakdowns and removed ice hockey (#23) (#24)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------

Co-authored-by: AdelynnWu <[email protected]>

* Release 1.0.0 Build 23 (#25)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------

Co-authored-by: Jayson Hahn <[email protected]>

* Increment marketing version

---------

Co-authored-by: AdelynnWu <[email protected]>

* Release Version 1.0.2 Build 26 (#28)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------

Co-authored-by: Jayson Hahn <[email protected]>

* Increment marketing version

* fix upcoming card icon (#27)

* Updated Build and version

---------

Co-authored-by: AdelynnWu <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>

* Release 1.0.3 Build 27 (#32)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------

Co-authored-by: Jayson Hahn <[email protected]>

* Increment marketing version

* fix upcoming card icon (#27)

* Updated README and added set-up instructions (#30)

* Set up Firebase Analytics (#29)

* Set up Firebase

* Removed previous TODO

* Resolved merge conflicts

---------

Co-authored-by: AdelynnWu <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Angelina Chen <[email protected]>
Co-authored-by: Angelina Chen <[email protected]>

* Create Package.resolved

* Release 1.0.3 Build 29

* Release 1.0.3 Build 30

---------

Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Jay Z. <[email protected]>
Co-authored-by: AdelynnWu <[email protected]>
Co-authored-by: Richie Sun <[email protected]>
Co-authored-by: Peter Bidoshi <[email protected]>
Co-authored-by: Peter <[email protected]>
@zainbilalh zainbilalh mentioned this pull request Oct 2, 2025
zainbilalh added a commit that referenced this pull request Oct 2, 2025
* Use different Bundle ID (#12)

* Testflight version 1 from main (#13)

* Use different Bundle ID

* Add ci_scripts and remove codegen file

* Add ci_scripts and Display Name

* Fix secrets ci_script issue

* Made script executable

* Made AppIcon square

* Ensure AppIcon has no transparency

* Release 1.0.0 Build 17 (#19)

* Merge release into Main (#15)

* Use different Bundle ID (#12)

* Testflight version 1 from main (#13)

* Use different Bundle ID

* Add ci_scripts and remove codegen file

* Add ci_scripts and Display Name

* Fix secrets ci_script issue

* Made script executable

* Made AppIcon square

* Ensure AppIcon has no transparency

* Added scrollview to opponent name (#10)

* added String extension file with a function to remove prefix for university of. Applied it to opponent names in game cards

* added comment to new string function

* reverse shorten University name, instead made it scrollable

* added scroll view to more views

* Delete Package.resolved

* made new textUtil file for string manipulation specifically for university name being too long, made it scrollable, added shadow to trailing to indicate scrollable. Shorten university of to U

* added comment to TextUtil.trailingFadeWhite

* PR Comment Fixed

- made new folder for ViewModifier and moved TrailingFadeGradient to withTrailingFadeGradient
- renamed TextUtil file to String+Extention

---------



* Adelynnwu/fix background bugs (#18)

* added ci_scripts and modified codegen

* refactor duplicated code in GameView, DynamicScoreBox, etc and implemented PastGameViewModel

* fixed game tile text color

* fixed game summary background and carousel card corner radius

* Some bug fixes

* fixed score box and game location display issue

* Prepare for testing attempt 1

* Fix merge bugs and set App Category & build

* Fix loading state bug

---------



---------




* fixed incosistenc score breakdowns and removed ice hockey (#23) (#24)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------



* Release 1.0.0 Build 23 (#25)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------



* Increment marketing version

---------



* Release Version 1.0.2 Build 26 (#28)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------



* Increment marketing version

* fix upcoming card icon (#27)

* Updated Build and version

---------




* Release 1.0.3 Build 27 (#32)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------



* Increment marketing version

* fix upcoming card icon (#27)

* Updated README and added set-up instructions (#30)

* Set up Firebase Analytics (#29)

* Set up Firebase

* Removed previous TODO

* Resolved merge conflicts

---------






* Create Package.resolved

* Release 1.0.3 Build 29

* Release 1.0.3 Build 30

---------

Co-authored-by: Angelina Chen <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Jay Z. <[email protected]>
Co-authored-by: AdelynnWu <[email protected]>
Co-authored-by: Richie Sun <[email protected]>
Co-authored-by: Peter Bidoshi <[email protected]>
Co-authored-by: Peter <[email protected]>
zainbilalh added a commit that referenced this pull request Oct 26, 2025
* Added 'highlights' icon to TabViewIcon

* merge main into implement-highlight-ui(#38)

* Use different Bundle ID (#12)

* Testflight version 1 from main (#13)

* Use different Bundle ID

* Add ci_scripts and remove codegen file

* Add ci_scripts and Display Name

* Fix secrets ci_script issue

* Made script executable

* Made AppIcon square

* Ensure AppIcon has no transparency

* Release 1.0.0 Build 17 (#19)

* Merge release into Main (#15)

* Use different Bundle ID (#12)

* Testflight version 1 from main (#13)

* Use different Bundle ID

* Add ci_scripts and remove codegen file

* Add ci_scripts and Display Name

* Fix secrets ci_script issue

* Made script executable

* Made AppIcon square

* Ensure AppIcon has no transparency

* Added scrollview to opponent name (#10)

* added String extension file with a function to remove prefix for university of. Applied it to opponent names in game cards

* added comment to new string function

* reverse shorten University name, instead made it scrollable

* added scroll view to more views

* Delete Package.resolved

* made new textUtil file for string manipulation specifically for university name being too long, made it scrollable, added shadow to trailing to indicate scrollable. Shorten university of to U

* added comment to TextUtil.trailingFadeWhite

* PR Comment Fixed

- made new folder for ViewModifier and moved TrailingFadeGradient to withTrailingFadeGradient
- renamed TextUtil file to String+Extention

---------



* Adelynnwu/fix background bugs (#18)

* added ci_scripts and modified codegen

* refactor duplicated code in GameView, DynamicScoreBox, etc and implemented PastGameViewModel

* fixed game tile text color

* fixed game summary background and carousel card corner radius

* Some bug fixes

* fixed score box and game location display issue

* Prepare for testing attempt 1

* Fix merge bugs and set App Category & build

* Fix loading state bug

---------



---------




* fixed incosistenc score breakdowns and removed ice hockey (#23) (#24)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------



* Release 1.0.0 Build 23 (#25)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------



* Increment marketing version

---------



* Release Version 1.0.2 Build 26 (#28)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------



* Increment marketing version

* fix upcoming card icon (#27)

* Updated Build and version

---------




* Release 1.0.3 Build 27 (#32)

* fixed incosistenc score breakdowns and removed ice hockey (#23)

* fixed incosistenc score breakdowns and removed ice hockey

* Remove tracking of GameAPI and change to fragments

* Remove default to prevent error

* Implement Temp Fix for pagination and add load more button

---------



* Increment marketing version

* fix upcoming card icon (#27)

* Updated README and added set-up instructions (#30)

* Set up Firebase Analytics (#29)

* Set up Firebase

* Removed previous TODO

* Resolved merge conflicts

---------






* Create Package.resolved

* Release 1.0.3 Build 29

* Release 1.0.3 Build 30

---------

Co-authored-by: Angelina Chen <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Jay Z. <[email protected]>
Co-authored-by: AdelynnWu <[email protected]>
Co-authored-by: Richie Sun <[email protected]>
Co-authored-by: Peter Bidoshi <[email protected]>
Co-authored-by: Peter <[email protected]>

* Fixed alignment issue with navbar

* added util to add corner radius on specified corners

* Made video highlight tile

* Made tile more representative of Figma design

* Added highlight view

* Added search bar (non-functional)

* separated videos and articles into separate views

* Added number of results

* Made tiles link to articles\videos

* fixed bug with project file

* keep branch's xcodeproj after merge

* merge updates from main

* added detailed highligh views

* added Dates utils for filtering based on date

* added filtering to highlights and refactored code

* refactored filtering logic

* added dummy data for testing

* refactored models into their respective files

* added search functionality

* capitalize T in YouTube

* style changes (newlines)

* Refactor tab system to use MainTab enum instead of arrays

* Added comment to clarify different paddings

* style changes

* added 2x and 3x versions of icons

* style changes

* Changed fonts and paddings to be consistent with other pages in the app

---------

Co-authored-by: Angelina Chen <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Jayson Hahn <[email protected]>
Co-authored-by: Jay Z. <[email protected]>
Co-authored-by: AdelynnWu <[email protected]>
Co-authored-by: Richie Sun <[email protected]>
Co-authored-by: Peter Bidoshi <[email protected]>
Co-authored-by: Peter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants