JavaScript: Add CI configuration for software tests and Dependabot #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/tests-javascript
branch
from
fe6f449 to
405aaff
Compare
Closed
seut
reviewed
May 23, 2024
| target = Antlr4Target.python | ||
| if input_target.startswith("py"): | ||
| target = Antlr4Target.python | ||
| elif input_target.startswith("js") or input_target.startswith("java"): |
Member
There was a problem hiding this comment.
why run js when using java? why is java an option?
Member
Author
There was a problem hiding this comment.
It's just a shorthand notation for "javascript".
Member
There was a problem hiding this comment.
ahh, thats why it works when running python setup_grammar.py javascript :D
I'd really prefer to use exact matches... but maybe personal preference.
surister
reviewed
May 23, 2024
surister
reviewed
May 23, 2024
seut
approved these changes
May 23, 2024
surister
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the title says. Accompanying the other corresponding patch about Python.