Python: Improve project setup and test runner conveniences after unboxing. Add CI configuration. Prepare packaging. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logging, to inform the user about different steps and input/output files when invoking the compilation/generation process. - Optimize file reading and writing using `pathlib`. - Add a few TODO/FIXME inline comments.
- A pytest `conftest.py` file will invoke the runtime grammar generator when the generated grammar module files do not exist. - By defining top-level Python package dependencies within a `requirements.txt` file, we can use Dependabot to drive dependency package upgrades.
amotl
force-pushed
the
amo/tests-python
branch
3 times, most recently
from
6b25d94 to
35c10f8
Compare
This was referenced May 17, 2024
surister
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
setup_grammar.pygrammar compiler/generatorDetails
I think Poetry will only be needed for larger or more complex projects. For a project like this, I think a vanilla setuptools-based
pyproject.tomlwill be enough.