Fix addApbChangeCallback(): duplicate func kernel msgs
#1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `IRrecv::enableIRn()` was called after a `IRrecv::disableIRn()` call the ESP32 would produce a kernel message/warning on the serial port. e.g.: ``` [E][esp32-hal-cpu.c:93] addApbChangeCallback(): duplicate func=400814C4 arg=3FFBDFC4 ``` if ESP32 IDF 3.3 (v1.0.5) was used. Fix the issue by ensuring a `timerEnd()` call is made in the `disableIRIn()` call to properly clean up the timer. Fixes #1434
NiKiZe
approved these changes
Mar 21, 2021
|
Thanks @NiKiZe. That was super fast! You even beat the CI/Travis checks, which I now need to wait for ... |
crankyoldgit
added a commit
that referenced
this pull request
Mar 24, 2021
_v2.7.16 (20210324)_ **[Features]** - ToshibaAC: Swing handling and `setRaw()` improvements. (#1423 #1424 #1425) - Support for XMP (Xfinity) protocol. (#1414 #1422) - ToshibaAC: Adjust inter-message gap timing to improve matching. (#1420 #1421) - Ecoclim: Add detailed A/C support (#1397 #1415) **[Misc]** - [ESP32] Fix `addApbChangeCallback(): duplicate func` kernel msgs (#1434 #1435) - refactor ir_Fujitsu (#1419) - refactor ir_Whirlpool (#1416) - refactor ir_Vestel (#1413) - refactor ir_Trotec (#1412)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Mar 24, 2021
## _v2.7.16 (20210324)_ **[Features]** - ToshibaAC: Swing handling and `setRaw()` improvements. (#1423 #1424 #1425) - Support for XMP (Xfinity) protocol. (#1414 #1422) - ToshibaAC: Adjust inter-message gap timing to improve matching. (#1420 #1421) - Ecoclim: Add detailed A/C support (#1397 #1415) **[Misc]** - [ESP32] Fix `addApbChangeCallback(): duplicate func` kernel msgs (#1434 #1435) - refactor ir_Fujitsu (#1419) - refactor ir_Whirlpool (#1416) - refactor ir_Vestel (#1413) - refactor ir_Trotec (#1412)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
IRrecv::enableIRn()was called after aIRrecv::disableIRn()call the ESP32 would produce a kernel message/warning on the serial port. e.g.:if the ESP32 IDF 3.3 (v1.0.5) was used.
Fix the issue by ensuring a
timerEnd()call is made in thedisableIRIn()call to properly clean up the timer.Tested on an ESP32dev board. Confirmed the message no longer appears.
Fixes #1434