Skip to content

ToshibaAC: Adjust inter-message gap timing to improve matching. #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

ToshibaAC: Adjust inter-message gap timing to improve matching. #1421

merged 1 commit into from
Mar 1, 2021

Conversation

@crankyoldgit
Copy link
Owner

  • Allow for a shorted inter-message gap to handle decoding a WH-UB03NJ remote.
    • A/C does accept the longer inter-message gap. (Confirmed)
  • Add unit test to confirm operation.
  • Update supported models.

Kudos to @nao-pon for collecting/analysing the data.

Fixes #1420

@crankyoldgit
ToshibaAC: Adjust inter-message gap timing to improve matching.
15c09fa 
* Allow for a shorted inter-message gap to handle decoding a WH-UB03NJ remote.
  - A/C does accept the longer inter-message gap. (Confirmed)
* Add unit test to confirm operation.
* Update supported models.

Kudos to @nao-pon for collecting/analysing the data.

Fixes #1420
@crankyoldgit crankyoldgit self-assigned this Feb 28, 2021
@crankyoldgit crankyoldgit mentioned this pull request Feb 28, 2021
Closed
@crankyoldgit crankyoldgit added Pending Confirmation Waiting for confirmation from user and removed Pending Confirmation Waiting for confirmation from user labels Feb 28, 2021
@crankyoldgit crankyoldgit merged commit 0d2dec3 into master Mar 1, 2021
@crankyoldgit crankyoldgit deleted the Issue1420 branch March 1, 2021 10:38
crankyoldgit added a commit that referenced this pull request Mar 24, 2021
@crankyoldgit
v2.7.16 release
85e83ef 
_v2.7.16 (20210324)_

**[Features]**
- ToshibaAC: Swing handling and `setRaw()` improvements. (#1423 #1424 #1425)
- Support for XMP (Xfinity) protocol. (#1414 #1422)
- ToshibaAC: Adjust inter-message gap timing to improve matching. (#1420 #1421)
- Ecoclim: Add detailed A/C support (#1397 #1415)

**[Misc]**
- [ESP32] Fix `addApbChangeCallback(): duplicate func` kernel msgs (#1434 #1435)
- refactor ir_Fujitsu (#1419)
- refactor ir_Whirlpool (#1416)
- refactor ir_Vestel (#1413)
- refactor ir_Trotec (#1412)
@crankyoldgit crankyoldgit mentioned this pull request Mar 24, 2021
Merged
crankyoldgit added a commit that referenced this pull request Mar 24, 2021
@crankyoldgit
v2.7.16 release (#1439)
38eacde 
## _v2.7.16 (20210324)_

**[Features]**
- ToshibaAC: Swing handling and `setRaw()` improvements. (#1423 #1424 #1425)
- Support for XMP (Xfinity) protocol. (#1414 #1422)
- ToshibaAC: Adjust inter-message gap timing to improve matching. (#1420 #1421)
- Ecoclim: Add detailed A/C support (#1397 #1415)

**[Misc]**
- [ESP32] Fix `addApbChangeCallback(): duplicate func` kernel msgs (#1434 #1435)
- refactor ir_Fujitsu (#1419)
- refactor ir_Whirlpool (#1416)
- refactor ir_Vestel (#1413)
- refactor ir_Trotec (#1412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

@siriuslzx siriuslzx Awaiting requested review from siriuslzx

Assignees

@crankyoldgit crankyoldgit

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Smaller kToshibaAcMinGap

2 participants

@crankyoldgit @NiKiZe