Skip to content

Conversation

Eric-Warehime
Copy link
Contributor

Description

Draft for integrating block stm.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

"io"
"os"
goruntime "runtime"
"sort"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
evmd/app.go Outdated
Comment on lines 297 to 300
allKeys = append(allKeys, k)
nonTransientKeys = append(nonTransientKeys, k)
}
for _, k := range tkeys {

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +304 to +307
allKeys = append(allKeys, k)
nonTransientKeys = append(nonTransientKeys, k)
}
sort.SliceStable(allKeys, func(i, j int) bool { return allKeys[i].Name() < allKeys[j].Name() })

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism

// Stack of cached store
cacheStores []storetypes.CacheKVStore
cacheStores []storetypes.CacheWrap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I felt a bit hacky like 04f5ae2 when doing cast for snapshotKVStore

vladjdk and others added 7 commits September 17, 2025 07:43
* cache erc20 precompile abis instead

* fix tests

* lints
* separate geth metrics server

* that should be a wrap

* changelog lol

* make server behave more like the others

* move port to 8100, fix quoting problem

* lint fix

* expose in dockerfile
* move default static precompiles creator out of app.go and set as defaults

* move defaults to precompile folder and use existing builder pattern

* undo interface changes on tests

* undo unnecessary changes

* fix tests

* lints

* add sum docs
* imp: make erc20keeper optional in x/vm

* add changelog

---------

Co-authored-by: Vlad J <[email protected]>
* test(mempool): setup e2e test suite for mempool testing

* WIP

* test(mempool): refactor test

* test(mempool): refactor system test suite

* test(systemtest): refactor mempool test

* test(systemtests): add cosmosClient

* test(systemtests): refactor mempool test

* test(systemtests): refactor mempool test

* test(systemtests): refactor mempool test

* test(systemtests): add txpool content verification to mempool tests

* test(systemtests): fix mempool test suite

* test(systemtests): fix mempool test suite

* test(systemtests): fix mempool tests

* test(systemtests): fix mempool test suite

* test(systemtests): fix mempool test suite

* test(systemtests): fix mempool test suite

* test(systemtests): add mempool test cases

* test(systemtests): add comments

* test(systemtests): chore: enable replacement tests

* chore: modify names of test cases

* test(systemtests): enhance helper functions

* test(systemtests): fix mempool test

* chore(systemtests): change test name and add readme.md

* chore: update CHANGELOG.md

* fix(proto): restore removed data field during merge

* test(systemtests): refactor

* test(systemtests): fix map iteration

* chore(systemtests): fix build tag

* test(systemtests): add test case for mempool

* test(systemtests): fix map iteration

* test(systemtests): refactor and add test case for --minimum-gas-prices=0stake

* test(systemtests): enhance validation

* fix: restore removed changes from merge

* fix: restore removed changes from merge

* fix: restore removed changes from merge

* fix: restore removed changes from merge

* chore(systemtests): rename test suite hooks

* fix(systemtests): fix test cases

* chore: modify mempool e2e test README.md

* test(systemtests): enhance post check of mempool test

* chore: apply codeQL feedback

* chore: update tests/systemtests/go.sum

* chore: go mod tidy

* fix(rpc): SendRawTransaction doesn't return error when tx.nonce is lower than pending nonce

* chore(systemtests): remove unused fields of RPCTransaction type

---------

Co-authored-by: Alex | Interchain Labs <[email protected]>
Co-authored-by: Vlad J <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants