refactor: move default precompiles out of evmd config #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
approved these changes
Sep 18, 2025
aljo242
approved these changes
Sep 18, 2025
Eric-Warehime
pushed a commit
that referenced
this pull request
Sep 19, 2025
* move default static precompiles creator out of app.go and set as defaults * move defaults to precompile folder and use existing builder pattern * undo interface changes on tests * undo unnecessary changes * fix tests * lints * add sum docs
yihuang
reviewed
Sep 22, 2025
| precompiletypes.DefaultStaticPrecompiles( | ||
| *app.StakingKeeper, | ||
| app.DistrKeeper, | ||
| app.BankKeeper, |
There was a problem hiding this comment.
It changed from the PreciseBankKeeper to normal BankKeeper here, is that intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #636
Moves the precompile instantiation to be in line with keeper instantiation, and moved the default precompile builder to the EVM repo instead of making people include this in their own repos.