Skip to content

migrated from dep to Go 1.11 modules #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gouthamve
Copy link
Contributor

Needs some automation in the Makefile. Will do that if you're okay with the change.

Copy link
Contributor

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending the Makefile update)

@bboreham
Copy link
Contributor

There are a bunch of libraries updated by this change; at least mention that in the description.
Ideally study the changes and identify any interesting updates or reasons for concern.

@bboreham
Copy link
Contributor

Some dependencies are mentioned in go.mod and some are not. What is the significance?
(e.g. go-grpc-middleware is and grpc-gateway is not)

Signed-off-by: Goutham Veeramachaneni <[email protected]>
@tomwilkie
Copy link
Contributor

Closing in favour of #1303

@tomwilkie tomwilkie closed this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants