Skip to content

cant build #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vtolstov opened this issue Mar 8, 2019 · 7 comments
Closed

cant build #1269

vtolstov opened this issue Mar 8, 2019 · 7 comments

Comments

@vtolstov
Copy link

vtolstov commented Mar 8, 2019

# github.com/cortexproject/cortex/pkg/ring
../../../.cache/go-path/pkg/mod/github.com/cortexproject/[email protected]/pkg/ring/batch.go:16:15: undefined: IngesterDesc
@bboreham
Copy link
Contributor

bboreham commented Mar 9, 2019

The latest CI build worked fine: https://circleci.com/gh/cortexproject/cortex/4978

If you're going to post an issue like this, you have to show exactly what you did to get there.
I note that mod appears in your error message, and the PR to move to Go Modules is as yet un-merged: #1232

@vtolstov
Copy link
Author

vtolstov commented Mar 10, 2019

Ah i see, error present in godoc too. You repo does not have some definition. Check https://godoc.org/github.com/cortexproject/cortex/pkg/ring#ReplicationSet for example. Can you push in git protoc generated structs too?
Firstly - because go get not works, second - understanding via godoc what struct returned or needed is very hard.

@vtolstov
Copy link
Author

vtolstov commented Mar 10, 2019

My problem because i'm try to go get grafana/loki but it fails, becasse for example ring package does not have some definition, that as i understand created via protoc

@tomwilkie
Copy link
Contributor

@vtolstov the vendored Cortex in Loki includes the protoc files. You should use the vendor, and not go mod for now. Use the makefile to build.

We have a separate issue to track committing generated files: #1224.

@vtolstov
Copy link
Author

thanks!

@bboreham
Copy link
Contributor

#1224 is not the issue you are looking for.

@vtolstov
Copy link
Author

can you create pr/issue to track including generated files in git repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants