Skip to content

Update README.md for ssl.ca.certificates #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chicagobuss
Copy link

@chicagobuss chicagobuss commented Feb 27, 2020

try number 2 to strike a balance between informative/useful/concise

try #2 to strike a balance between informative/useful/concise
@chicagobuss chicagobuss requested a review from edenhill February 27, 2020 20:13
@ghost
Copy link

ghost commented Feb 27, 2020

@confluentinc It looks like @chicagobuss just signed our Contributor License Agreement. 👍

Always at your service,

clabot

package which needs to be installed through `apt`, `yum`, et.al.

On MacOS, different versions can store CA certificates in different locations.
On MacOS Mojave and later, for instance, this is usually ` '/private/etc/ssl/cert.pem'`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is entirely accurate. I think the bundled openssl version may look there but MacOS itself stores them in the keychain database. I believe this to be the reason why openssl s_client -connect works but the Python client complains. It'd be good to verify this statement prior to proceeding as this may be one of those "works on my machine" type situations rather than works on MacOS Mojave+.

package which needs to be installed through `apt`, `yum`, et.al.

On MacOS, different versions can store CA certificates in different locations.
On MacOS Mojave and later, for instance, this is usually ` '/private/etc/ssl/cert.pem'`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent formatting, drop the '.

@edenhill edenhill changed the title Update README.md Update README.md for ssl.ca.certificates Mar 9, 2021
@cla-assistant
Copy link

cla-assistant bot commented Aug 15, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Joshua Buss seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants