-
Notifications
You must be signed in to change notification settings - Fork 915
Update README.md for ssl.ca.certificates #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chicagobuss
wants to merge
1
commit into
master
Choose a base branch
from
readme-ssl-macos-recommendation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -270,16 +270,22 @@ authentication is used). | |
|
||
The client will use CA certificates to verify the broker's certificate. | ||
The embedded OpenSSL library will look for CA certificates in `/usr/lib/ssl/certs/` | ||
or `/usr/lib/ssl/cacert.pem`. CA certificates are typically provided by the | ||
Linux distribution's `ca-certificates` package which needs to be installed | ||
through `apt`, `yum`, et.al. | ||
or `/usr/lib/ssl/cacert.pem`. | ||
|
||
On Linux, CA certificates are typically provided by the distribution's `ca-certificates` | ||
package which needs to be installed through `apt`, `yum`, et.al. | ||
|
||
On MacOS, different versions can store CA certificates in different locations. | ||
On MacOS Mojave and later, for instance, this is usually ` '/private/etc/ssl/cert.pem'`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inconsistent formatting, drop the |
||
|
||
If your system stores CA certificates in another location you will need to | ||
configure the client with `'ssl.ca.location': '/path/to/cacert.pem'`. | ||
|
||
Alternatively, the CA certificates can be provided by the [certifi](https://pypi.org/project/certifi/) | ||
Python package. To use certifi, add an `import certifi` line and configure the | ||
client's CA location with `'ssl.ca.location': certifi.where()`. | ||
A more generic and fool-proof way to ensure SSL works is to install the | ||
[certifi](https://pypi.org/project/certifi/) Python package, which provides its own | ||
bundled CA certificates, much like how Java works. To use certifi, install it, and then | ||
add an `import certifi` line and configure the client's CA location with | ||
`'ssl.ca.location': certifi.where()`. | ||
|
||
|
||
Prerequisites | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is entirely accurate. I think the bundled openssl version may look there but MacOS itself stores them in the keychain database. I believe this to be the reason why
openssl s_client -connect
works but the Python client complains. It'd be good to verify this statement prior to proceeding as this may be one of those "works on my machine" type situations rather than works on MacOS Mojave+.