Support using array segments for serializers #1782
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the primary serializer interface to return an ArraySegment-wrapped byte array in favor of the byte array itself. It then uses the resulting count and offset fields to be passed into the produce call. The new interface also supports a Release hook which can be used after the produce call has happened.
The primary use case is to allow for pooled arrays to be written to, or recycled streams' internal buffers. This helps a lot when writing data greater than 85K which would ordinary require LOH allocations and greatly impact the performance of the service.
I made the adjustment so there should be no breaking changes - the builder interfaces just "upgrade" the old variant serializers by wrapping them. The producer class internally uses the new interfaces only. The release methods are no-op on the wrapped serializers.
This may provide very similar functionality to #1725 without an API break