Improve serialization memory management #1725
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
ISerializer
andIAsyncSerializer
interfaces force an implementation to return a byte array with exact size. This approach effectively makes pooling impossible and often requires expensive memory copies and additional allocations in serializer implementations. See ProtobufSerializer as an example.This PR changes the memory management for serialization. Instead of relying on serializer implementations to return a byte array, they are given an IBufferWriter to write to.
void Serialize(T data, SerializationContext context, IBufferWriter<byte> bufferWriter);
The producer implementation will then supply a buffer writer implementation that internally uses ArrayPool to allocate the memory. Users can overwrite this implementation by setting a custom ISerializationBufferProvider.