feat: add PartialClaudeCodeConfig type for better configuration handling #115
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 8, 2025
ThomasK33
force-pushed
the
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
branch
from
44647fb to
b350b53
Compare
ThomasK33
force-pushed
the
thomask33/feat_add_PartialClaudeCodeConfig_type_for_better_configuration_handling
branch
from
004c32f to
4ccf295
Compare
Change-Id: I7e94c9ebbace3654b1f1cfad8b0e3f3899c786cb Signed-off-by: Thomas Kosiewski <[email protected]>
ThomasK33
force-pushed
the
thomask33/feat_add_on_new_file_reject_option_to_control_empty_buffer_behavior
branch
from
b350b53 to
0bcb677
Compare
ThomasK33
force-pushed
the
thomask33/feat_add_PartialClaudeCodeConfig_type_for_better_configuration_handling
branch
from
4ccf295 to
cc09df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce PartialClaudeCodeConfig type for better type checking
This PR introduces a new
PartialClaudeCodeConfigtype that extends the existingClaudeCodeConfigtype. The type signature for thesetupfunction and the dev-config have been updated to use this new type, which better represents that configuration options are partial and can be overridden.This change improves type checking and makes it clearer that the configuration passed to
setup()doesn't need to include all possible options.