-
Notifications
You must be signed in to change notification settings - Fork 63
feat: redesign diff view with horizontal layout and new tab options #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: redesign diff view with horizontal layout and new tab options #111
Conversation
a465640
to
9c74ead
Compare
82aff2b
to
9734f3f
Compare
4ae7572
to
0f7c9ba
Compare
0f7c9ba
to
7ab50da
Compare
@ThomasK33 thanks for the fix! The only issue I noticed so far is that after the accept/reject, the new tab remains opened (just not active), so I end up with bunch of tabs opened - one per each diff. |
Actually, if I reject (with a keymap, not via CC cli menu) - the new tab is closed, but Claude Code split is gone as well. |
Also, after accepting, the inner terminal width becomes wider and goes off-screen until I close all diff tabs and refocus the claude code window. |
Change-Id: Ia8df210bad3a05b7eddd92fafbbb4f8aa90e2704 Signed-off-by: Thomas Kosiewski <[email protected]>
7ab50da
to
f8c7db8
Compare
Got it, thanks @alex35mil. I've removed the tab and diff closing parts and am waiting for Claude Code to send a tab close tool call. When accepting or denying a diff now, it seems to close the tab and diff correctly. |
@ThomasK33 Tested the update. Everything seems to be fixed except I need to refocus the Claude window to fix its width after accept/reject with keymap - it still goes off screen after these actions. Also, another idea for the diff in a new tab - having an option to hide the Claude window in the new tab with diff, thus there's more screen estate for reviewing the diff. I find myself not looking at the Claude output during the review, so it's a waste of screen space. |
Oh, and I just noticed a bunch of unnamed buffers created after the accept/reject dance in the new tab. |
Is it possible to have an option to disable the Neovim diff view entirely (so to just use the diff provided directly in claudecode)? Maybe something like diff_opts = {
enabled = true
-- other diff opts ...
} The new field I've decided to comment here because I've noticed this PR is about a diff view redesign, and I think this is something related to that. If you prefer, I can open a separate issue. |
Nope, won't be adding that. You can configure that in Claude Code itself. See: #45 (comment) |
Improved Diff View Layout and Configuration
This PR refactors the diff view functionality to provide more flexible layout options and better tab management:
layout
option to replace the previousvertical_split
boolean, supporting both "vertical" and "horizontal" layoutsopen_in_current_tab
withopen_in_new_tab
for more intuitive configurationauto_close_on_accept
andshow_diff_stats
that were no longer usedThese changes make the diff view more customizable while simplifying the configuration interface. Users can now choose between vertical or horizontal layouts and easily open diffs in new tabs while maintaining access to the terminal.