Skip to content

Conversation

kikuKeii
Copy link
Contributor

Description
new pull request from #912
did I do it right this time?

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the lang Languages file label Oct 17, 2023
@kenjis kenjis changed the title add translation ID lang: [id] add translation Oct 17, 2023
@kenjis
Copy link
Member

kenjis commented Oct 17, 2023

Thank you. GPG sigining is okay.

But Language Unit Tests failed.
If the translation of Auth.token is the same as English, add $excludedLocaleKeyTranslations in the test class for id.
Here is the test class for Italian as a reference:

protected array $excludedLocaleKeyTranslations = [
'Auth.password',
'Auth.login',
];

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@kikuKeii thank you!

@datamweb datamweb merged commit 0cd5f3f into codeigniter4:develop Oct 17, 2023
@kikuKeii
Copy link
Contributor Author

@kenjis @datamweb Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang Languages file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants