Skip to content

Conversation

mieszkou
Copy link
Contributor

I added a Polish translation of the texts

@mieszkou mieszkou changed the title Polish translation [lang] Polish May 12, 2024
@mieszkou mieszkou changed the title [lang] Polish lang: Polish May 12, 2024
@datamweb datamweb added GPG-Signing needed Pull requests that need GPG-Signing tests needed Pull requests that need tests labels May 12, 2024
@datamweb
Copy link
Collaborator

Hi,
Thank you for contributing!
Please see #235 (comment)

@datamweb datamweb added the lang Languages file label May 12, 2024
@datamweb datamweb changed the title lang: Polish lang: [pl] add Polish translation May 12, 2024
@kenjis
Copy link
Member

kenjis commented May 14, 2024

Please fix the following failure.

There was 1 failure:

1) Tests\Language\PolishTranslationTest::testAllIncludedLanguageKeysAreTranslated with data set "pl" ('pl')
Failed asserting that the translated language key "Auth.token" in "pl" locale differs from the original keys in the main repository.
Failed asserting that an array is empty.

/home/runner/work/shield/shield/tests/Language/AbstractTranslationTestCase.php:259

https://github.com/codeigniter4/shield/actions/runs/9068936216/job/24922062972?pr=1117

@datamweb datamweb removed the tests needed Pull requests that need tests label May 18, 2024
@datamweb
Copy link
Collaborator

@mieszkou thank you!
The last thing to do is to sign all the commits.

Screenshot 2024-05-18 191831

It is explained gpg-signing-old-commits.

As a faster alternative, you can still securely sign commits without the -S option in git commit. See Set Default Signing.

mieszkou and others added 17 commits May 18, 2024 18:07
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
Co-authored-by: Michal Sniatala <[email protected]>
@datamweb datamweb removed the GPG-Signing needed Pull requests that need GPG-Signing label May 19, 2024
@datamweb datamweb requested a review from michalsn May 19, 2024 00:09
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@datamweb datamweb merged commit b942c47 into codeigniter4:develop May 19, 2024
@datamweb
Copy link
Collaborator

@mieszkou Welcome to Shield Contributors!
Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang Languages file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants