Skip to content

update covidcast 'firstDate' #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

update covidcast 'firstDate' #108

merged 1 commit into from
Mar 17, 2025

Conversation

melange396
Copy link
Contributor

Copy link

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I wonder why we use the firstDate param at all. I assume we always want to show the full history of an indicator.

@melange396
Copy link
Contributor Author

@nmdefries : you raise a good point that i, myself, have wondered. The "first date" concept precedes the big svelete rewrite in May 2021, and even the 2nd commit to this repo which imported the old epivis code in November 2016:

// first available epiweek for each data source
var first_epiweek = {
'fluview': 199740,
'ilinet': 199740,
'stateili': 201001,
'gft': 200340,
'ght': 200401,
'twitter': 201148,
'wiki': 200750,
'nidss_flu': 200814,
'nidss_dengue': 200301,
'signals': 200340,
'cdc': 201301,
'sensors': 201030,
'nowcast': 200901,
};
// first available date for each data source
var first_date = {
'twitter': 20111201,
'wiki': 20071209,
};

It mightve been a requirement from how older versions of endpoints and/or indexes worked, or just a premature optimization.

@melange396 melange396 merged commit bbef53e into dev Mar 17, 2025
6 checks passed
@melange396 melange396 deleted the update_covidcast_firstdate branch March 17, 2025 21:27
@melange396 melange396 mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust firstDate and firstEpiWeek for covidcast endpoint
2 participants