-
Notifications
You must be signed in to change notification settings - Fork 3
Release 7.0.0 #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 7.0.0 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UI defines startup selection values globally, for all users assigned to that Shiny session. Startup values are treated as constants, so a hard-coded asof date won't update if the Shiny session persists (is continually used) across a date boundary that would normally change the default asof selection. Thus, we need to set the starting asof value on a user-by-user basis so that it is recalculated when a new dashboard instance is opened. To do that, set the initial asof value back to empty ("") and run an updater observe on dashboard startup only. In reality, this is practically unimportant; we don't have enough dashboard users to persist Shiny sessions very long.
…r-switch Reduce unnecessary replotting on dashboard startup and on target variable switching
Move `PREV_TARGET` to session-specific global to not leak behavior between users
Simplify `dplyr` use in dashboard `filter` logic
…caster-change regenerate truth plot if aggregating over shared states
When changing score to/from coverage, show main plot and make sure truth data is relevant
krivard
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
confirmed backward-incompatible with 6.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing 7.0.0.
PREV_TARGET
to session-specific global to not leak behavior between users #267dplyr
use in dashboardfilter
logic #266