Simplify dplyr use in dashboard filter logic
#266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
approved these changes
Apr 18, 2023
Comment on lines
+61
to
+67
| scoreDf$ahead_group <- case_when( | ||
| scoreDf$ahead >= HOSPITALIZATIONS_OFFSET & scoreDf$ahead < 7 + HOSPITALIZATIONS_OFFSET ~ 1L, | ||
| scoreDf$ahead >= 7 + HOSPITALIZATIONS_OFFSET & scoreDf$ahead < 14 + HOSPITALIZATIONS_OFFSET ~ 2L, | ||
| scoreDf$ahead >= 14 + HOSPITALIZATIONS_OFFSET & scoreDf$ahead < 21 + HOSPITALIZATIONS_OFFSET ~ 3L, | ||
| scoreDf$ahead >= 21 + HOSPITALIZATIONS_OFFSET & scoreDf$ahead < 28 + HOSPITALIZATIONS_OFFSET ~ 4L, | ||
| TRUE ~ NA_integer_ | ||
| ) |
There was a problem hiding this comment.
praise: this is a beautiful refactor
| filteredScoreDf[, c("Forecaster", "Forecast_Date", "Week_End_Date", "Score", "ahead")], | ||
| !is.na(Week_End_Date) | ||
| ) | ||
| filteredScoreDf$Score <- round(filteredScoreDf$Score, 2) |
There was a problem hiding this comment.
extra explanation for future travelers:
This change is equivalent.
Score is the only column where rounding to 2 decimal places will have any effect.
ahead is numeric but takes integer values.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dplyr-based processing steps simpler and fasterdata.table's character vector-optimized "in" operator,%chin%, in slow filter stepsdata.table'swdayfunction to get weekday name from dates