Skip to content

Add template refactor back #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 2, 2021
Merged

Add template refactor back #205

merged 25 commits into from
Dec 2, 2021

Conversation

nmdefries
Copy link
Collaborator

Add template refactor changes back into dev, reverting #193 and #196. Add in changes to fix a few bugs that appeared in the refactor.

@nmdefries nmdefries requested review from krivard and sgratzl October 14, 2021 00:04
krivard
krivard approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict this is as good as the previous one, though I didn't catch the problems in the previous one either :(

some day we'll have tests in this repo

@nmdefries
Merge pull request #210 from cmu-delphi/fix-truth-plot-startup-colors
94ccbe2 
Track color seed in session var
@nmdefries
modify layout css to support resizing
0f49364
@nmdefries
Merge pull request #211 from cmu-delphi/full-territory-names
9c8f8d8 
Display full names for states and territories
@nmdefries
Merge pull request #206 from cmu-delphi/fix-missing-messages
6ab76a9 
Make sure score explanations appear at the right time
@nmdefries
Merge pull request #212 from cmu-delphi/fix-resizing
ae709d6 
Modify layout css to support resizing with browser window
@nmdefries
Merge pull request #204 from cmu-delphi/small-code-simplifications
e6a2fe8 
Small style fixes
@nmdefries
Merge pull request #202 from cmu-delphi/gray-out-show-forecasts
36f014f 
Gray out showForecasts button
@nmdefries
move legend title setting to plotly::layout
8c1c056
@nmdefries
move height setting back to layout
efaf9dc 
because it interferes with subplot spacing
@nmdefries
styling
8c51760
@nmdefries
Merge pull request #213 from cmu-delphi/fix-legend-labels
2af3a3c 
Suppress legend labels
@nmdefries nmdefries merged commit bf965b3 into dev Dec 2, 2021
@nmdefries nmdefries deleted the add-template-refactor-back-plus-patches branch December 2, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgratzl sgratzl Awaiting requested review from sgratzl

1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmdefries @krivard