Skip to content

Small style fixes #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2021
Merged

Small style fixes #204

merged 4 commits into from
Nov 5, 2021

Conversation

nmdefries
Copy link
Collaborator

@nmdefries nmdefries commented Oct 12, 2021 •
edited
Loading

Changes

  • Switch default selected forecaster back to baseline now that it contains hosp scores.
  • Clarify that dimension-based logic is looking at number of rows.
  • Clean up plot settings to eliminate frequent warnings.
  • Clarify what types of joins merge is doing (results are the same doing it both ways, although sorting may be different).

@nmdefries nmdefries marked this pull request as draft October 15, 2021 14:47
@nmdefries nmdefries changed the title Small code fixes Small style fixes Oct 15, 2021
@nmdefries nmdefries changed the base branch from dev to add-template-refactor-back-plus-patches October 15, 2021 19:24
@nmdefries nmdefries marked this pull request as ready for review November 4, 2021 14:24
@nmdefries nmdefries requested a review from krivard November 4, 2021 14:24
krivard
krivard approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmdefries nmdefries merged commit e6a2fe8 into add-template-refactor-back-plus-patches Nov 5, 2021
@nmdefries nmdefries deleted the small-code-simplifications branch November 5, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmdefries @krivard