Skip to content

Conversation

@aknysh
Copy link
Member

@aknysh aknysh commented Jun 21, 2019

what

why

  • The PR needs improvements, does not work reliably in all cases
  • When invoked with this configuration
max_subnet_count     = 4
public_subnet_count  = 2
private_subnet_count = 4

terraform apply produces these errors each time it runs with exactly the same settings including the number of provided AZs in var.availability_zones:

aws_subnet.private.0: Error creating subnet: InvalidParameterValue: Value (us-west-1b) for parameter availabilityZone is invalid. Subnets can currently only be created in the following availability zones: us-west-1c, us-west-1a.

aws_subnet.public.0: Error creating subnet: InvalidParameterValue: Value (us-west-1a) for parameter availabilityZone is invalid. Subnets can currently only be created in the following availability zones: us-west-1b, us-west-1c.

TODO

  • Check the logic in the case when max_subnet_count is greater than the number of provided AZs

@aknysh aknysh requested a review from osterman June 21, 2019 02:27
@aknysh aknysh self-assigned this Jun 21, 2019
@aknysh aknysh merged commit 5cb8cfe into master Jun 21, 2019
@aknysh aknysh deleted the revert-54-feature/set_subnet_counts branch June 21, 2019 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants