Feature/set subnet counts #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or private). Added Example
… nested aws provider within the module
Contributor
Author
|
This closes #33 |
Contributor
Author
|
This closes #36 |
… nested aws provider within the module
aknysh
reviewed
Jun 12, 2019
variables.tf
Outdated
| variable "max_subnet_count" { | ||
| default = 0 | ||
| description = "Sets the maximum amount of subnets to deploy. 0 will deploy a subnet for every provided availablility zone (in `availability_zones` variable) within the region" | ||
| locals { |
Member
There was a problem hiding this comment.
remove locals from variables.tf and place into other TF files, e.g main.tf
Contributor
Author
There was a problem hiding this comment.
I have revised.
…cals in to it. Moved the public and private subnet locals into public.tf and private.tf.
Contributor
Author
|
This pull also resolves the issue brought up in #55 by having the region variable pass to the provider correctly, as it was missing before. |
osterman
reviewed
Jun 12, 2019
Member
|
@Jamie-BitFlight please rebase. We've added tests. |
Contributor
Author
|
@osterman its rebased! |
osterman
approved these changes
Jun 20, 2019
Merged
Merged
aknysh
added a commit
that referenced
this pull request
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
made the
availability_zoneslist variable optional, when left empty it will use all az's available, otherwise it will only use the az's provided in the list.max_subnet_countvariable is depreciated, but kept in for now for backwards compatibility.By default max_subnet_count is
-1which makes its length equivalent to the number of availability zones in the region or if AZ's are provided, it uses that number instead.If you are wanting to use 3 AZ's, but create 100 public subnets, you would need to set this value to
100for now. In the future, this variable will be removed in favour of just setting a limit on the public, or private subnets.added
private_subnet_countvariable which can take a value of-1to create a 1:1 subnet to availability zone count, a value of0will create no private subnets, and any other value will create that many subnets, to a max ofmax_subnet_count.added
public_subnet_countvariable which can take a value of-1to create a 1:1 subnet to availability zone count, a value of0will create no public subnets, and any other value will create that many subnets, to a max ofmax_subnet_count.why
I needed a dynamic subnet that was public only for a project I was on, but found that this module would create an even number of private subnets that weren't being used. I wanted to tidy this up so one could specify the number of subnets of public or private type that were needed.