Define command to run -main #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cider-interaction.el
Outdated
There was a problem hiding this comment.
It's be better to move this inlined code to a simple middleware op.
There was a problem hiding this comment.
Which middleware would you put it in? info? ns?
There was a problem hiding this comment.
But Idk... Isn't this a little narrow for a middleware?
There was a problem hiding this comment.
I'd put it in ns. Middleware shouldn't be complex - it should just get some work done. The problem with evaluating strings is twofold:
- The meaning of the code is obscured by implementation details
- Even simple code can be problematic (in your case you're not using FQ names, which means that in some namespaces this code will misbehave)
|
All added. Along with clojure-emacs/cider-nrepl#221 |
cider-interaction.el
Outdated
There was a problem hiding this comment.
Btw, shouldn't this cover the option of function being used?
|
Tests added and name fixed. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1011.
Something like this?
Not sure where to bind it.