Migrate iotg watchdog (New)

[stanley31huang]

Description

for the watchdog tests, I have made some changes for the implementation in the #1125.

the major changes is to probe watchdog kernel module when the watchdog is not available by default for the watchdog/detect test and watchdog/trigger-system-reset-auto test.

Resolved issues

Documentation

Tests

[LiaoU3]

Please see my comment.

[stanley31huang]

Here is the test results with latest commits/
https://certification.canonical.com/hardware/202309-32027/submission/437298/

[LiaoU3]

I am good with the change, thank you! Please complete the rest of the unit test.

[codecov]

Codecov Report

❌ Patch coverage is 94.68085% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.31%. Comparing base (56dcd35) to head (05e1442).
⚠️ Report is 104 commits behind head on main.

Files with missing lines	Patch %	Lines
providers/base/bin/watchdog_test.py	93.37%	7 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
+ Coverage   51.03%   51.31%   +0.27%     
==========================================
  Files         385      386       +1     
  Lines       41507    41668     +161     
  Branches     7712     7734      +22     
==========================================
+ Hits        21184    21380     +196     
+ Misses      19563    19525      -38     
- Partials      760      763       +3     

Flag	Coverage Δ
provider-base	26.86% <93.61%> (+0.95%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rickwu666666]

I found some error while runing detect job.

-------------------[ Detect presence of a Hardware Watchdog ]-------------------
ID: com.canonical.certification::watchdog/detect
Category: Power Management tests
--------------------------------------------------------------------------------
# Perform watchdog detection test
Traceback (most recent call last):
  File "/tmp/nest-uylnar1g.8b90791d9334c3bb6c697e89d47e85aff59ed5e552c0aed4bcf935a1c72d6069/watchdog_test.py", line 406, in <module>
    main()
  File "/tmp/nest-uylnar1g.8b90791d9334c3bb6c697e89d47e85aff59ed5e552c0aed4bcf935a1c72d6069/watchdog_test.py", line 391, in main
    watchdog_detection_test(args.module, args.identity)
  File "/tmp/nest-uylnar1g.8b90791d9334c3bb6c697e89d47e85aff59ed5e552c0aed4bcf935a1c72d6069/watchdog_test.py", line 298, in watchdog_detection_test
    with probe_watchdog_module(watchdog_module):
  File "/snap/checkbox24/current/usr/lib/python3.12/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/tmp/nest-uylnar1g.8b90791d9334c3bb6c697e89d47e85aff59ed5e552c0aed4bcf935a1c72d6069/watchdog_test.py", line 126, in probe_watchdog_module
    ret = subprocess.run("modprobe {}".format(kernel_module))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/snap/checkbox24/current/usr/lib/python3.12/subprocess.py", line 548, in run
    with Popen(*popenargs, **kwargs) as process:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/snap/checkbox24/current/usr/lib/python3.12/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/snap/checkbox24/current/usr/lib/python3.12/subprocess.py", line 1955, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'modprobe rzg2l_wdt'

[LiaoU3]

+1

[rickwu666666]

LGTM

[pieqq]

Hi @stanley31huang !

I started to look at this, but before I dive deeper and provide line-by-line review, could you:

• Rebase your PR on the latest commit from main
• Provide some general explanation on what this change brings? I'm asking because, for instance in the original script, a mention was added stating that "with this change watchdog/systemd-config tests only systemd configuration on 20.04 and later series while keeping the original test for prior releases", but it's not clear where the original test is kept, since most of the functions in watchdog_config_test.py have been modified.
• Fill in the "Tests" section to provide submissions showing successful runs and steps on how to test this locally (or with a container, etc.)

[stanley31huang]

I have separated this PR into two PR. one for test job and the other one is for test scripts
test job: #2021
test scripts: #2022

so closed this one.