revised scripts and unit test

revised scripts and unit test

Author: stanley31huang

providers/base/bin/watchdog_test.py

@@ -123,19 +123,16 @@ def probe_watchdog_module(kernel_module):
     """
     ret = None
     # probe watchdog kernel module if it's not exists
-    ret = subprocess.run(
-        shlex.split("modprobe {}".format(kernel_module))
-    )
+    ret = subprocess.run(shlex.split("modprobe {}".format(kernel_module)))
     time.sleep(2)
     try:
         yield
     except Exception as err:
         print(err)
     finally:
         if ret and ret.returncode == 0:
-            subprocess.run(
-                shlex.split("modprobe -r {}".format(kernel_module))
-            )
+            cmd = "modprobe -r {}".format(kernel_module)
+            subprocess.run(shlex.split(cmd))
 
 
 def collect_hardware_watchdogs(watchdog_identity: str = "") -> dict:

providers/base/tests/test_watchdog_test.py

@@ -76,7 +76,10 @@ def test_probe_watchdog_module(self, mock_run, mock_sleep):
         mock_run.return_value = mock_result
         with probe_watchdog_module("kernel"):
             pass
-        calls = [call(["modprobe", "kernel"]), call(["modprobe", "-r", "kernel"])]
+        calls = [
+            call(["modprobe", "kernel"]),
+            call(["modprobe", "-r", "kernel"]),
+        ]
         mock_sleep.assert_called_with(2)
         mock_run.assert_has_calls(calls)