Skip to content

Conversation

@robert-smartbear
Copy link
Contributor

Goal

A Loading indicator with the new name property set will create a firstClass span for the duration of the indicator being active. The span will be nested under the ViewLoad span.

Changeset

  • Added a new name property to BugsnagPerformanceLoadingIndicatorView class
  • Creating spans for BugsnagPerformanceLoadingIndicatorView instances that have a name

Testing

E2E tests

@github-actions
Copy link

BugsnagPerformance.framework binary size increased by 6,568 bytes from 944,440 to 951,008

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  +168% +9.59Ki    [__LINKEDIT]
  +1.4% +3.84Ki  +1.4% +3.84Ki    String Table
  +1.2% +2.52Ki  +1.2% +2.52Ki    Symbol Table
  +0.8% +1.61Ki  +0.8% +1.61Ki    __TEXT,__text
  +3.0% +1.03Ki  +3.0% +1.03Ki    __DATA,__objc_const
  +1.8%    +452  +1.8%    +452    __TEXT,__objc_methname
  +1.9%    +352  +1.9%    +352    __TEXT,__objc_stubs
  +4.4%    +160  +4.4%    +160    __DATA,__objc_data
  +0.7%    +148  +0.7%    +148    __TEXT,__gcc_except_tab
  +1.8%     +88  +1.8%     +88    __DATA,__objc_selrefs
  +0.9%     +80  +0.9%     +80    __TEXT,__unwind_info
  +0.5%     +72  +0.5%     +72    __DATA_CONST,__const
  +5.0%     +72  +5.0%     +72    __TEXT,__objc_classname
  +0.6%     +58  +0.6%     +58    __TEXT,__cstring
  +2.2%     +48  +2.2%     +48    Rebase Info
  +3.6%     +28  +3.6%     +28    __DATA,__objc_ivar
  +1.0%     +24  +1.0%     +24    Function Start Addresses
  +0.5%     +24  +0.5%     +24    [3 Others]
  -1.0%     -88  -1.0%     -88    [__DATA_CONST]
 -67.1% -1.32Ki -72.3% -1.32Ki    [__DATA]
  -6.6% -2.75Ki  -6.6% -2.75Ki    [__TEXT]
  +0.7% +6.41Ki  +1.7% +16.0Ki    TOTAL

Generated by 🚫 Danger

@robert-smartbear robert-smartbear force-pushed the robert/plat-15009_loading_indicator_name branch from b691799 to 4fedc81 Compare October 27, 2025 01:48
@robert-smartbear robert-smartbear force-pushed the robert/plat-15009_loading_indicator_name branch from 4fedc81 to 2a469e0 Compare October 27, 2025 02:57
@robert-smartbear
Copy link
Contributor Author

Closing. The feature will be implemented directly on v2

@robert-smartbear robert-smartbear deleted the robert/plat-15009_loading_indicator_name branch October 29, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants