Fixes

Author: Robert Bartoszewski

Sources/BugsnagPerformance/Private/Instrumentation/ViewLoadInstrumentation/Lifecycle/LoadingIndicators/ViewLoadLoadingIndicatorsHandlerImpl.h

@@ -21,9 +21,9 @@ namespace bugsnag {
 class ViewLoadLoadingIndicatorsHandlerImpl: public ViewLoadLoadingIndicatorsHandler {
 public:
     ViewLoadLoadingIndicatorsHandlerImpl(std::shared_ptr<ViewLoadInstrumentationStateRepository> repository,
-                                         std::shared_ptr<ViewLoadSpanFactory> spanFactory_) noexcept
+                                         std::shared_ptr<ViewLoadSpanFactory> spanFactory) noexcept
     : repository_(repository)
-    , spanFactory_(spanFactory_) {}
+    , spanFactory_(spanFactory) {}
 
     void onLoadingIndicatorWasAdded(BugsnagPerformanceLoadingIndicatorView *loadingIndicator) noexcept;
     void onViewControllerUpdatedView(UIViewController *viewController) noexcept;
@@ -35,7 +35,7 @@ class ViewLoadLoadingIndicatorsHandlerImpl: public ViewLoadLoadingIndicatorsHand
     std::shared_ptr<ViewLoadInstrumentationStateRepository> repository_;
     std::shared_ptr<ViewLoadSpanFactory> spanFactory_;
     std::mutex mutex_;
-    ViewLoadLoadingIndicatorsHandlerCallbacks *callbacks_;
+    ViewLoadLoadingIndicatorsHandlerCallbacks *callbacks_{nullptr};
 
     void updateIndicatorsState(BugsnagPerformanceLoadingIndicatorView *loadingIndicator, ViewLoadLoadingIndicatorState *state) noexcept;
     ViewLoadLoadingIndicatorState *newState(BugsnagPerformanceLoadingIndicatorView *loadingIndicator) noexcept;

features/default/loading_indicator.feature

@@ -375,7 +375,7 @@ Feature: LoadingIndicator view to mark data loading phase
     And I wait for 1 second
     * no span field "name" equals "[ViewLoad/UIKit]/Fixture.LoadingIndicatorViewNestedViewStopScenario_ParentViewController"
     And I invoke "finishLoadingParentInner"
-    And I wait for 31 spans
+    And I wait for 32 spans
     Then the trace "Content-Type" header equals "application/json"
     * the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
     * a span field "name" equals "[ViewLoad/UIKit]/Fixture.LoadingIndicatorViewNestedViewStopScenario_ParentViewController"