Skip to content

types for Storage classes #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions iocage/lib/StandaloneJailStorage.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,25 @@
# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
# IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.
import iocage.lib.Storage


class StandaloneJailStorage:
def apply(self, release):
class StandaloneJailStorage(iocage.lib.Storage.Storage):

def apply(
self,
release: 'iocage.lib.Release.ReleaseGenerator'
) -> None:

self.logger.warn(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger is still not part of this class

"Standalone jails do not require storage operations to start",
jail=self.jail
)

def setup(self, release):
def setup(
self,
release: 'iocage.lib.Release.ReleaseGenerator'
) -> None:

self.logger.verbose("Cloning the release once to the root dataset")
self.clone_release(release)