types for Storage classes #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalic
reviewed
Oct 4, 2017
iocage/lib/StandaloneJailStorage.py
Outdated
|
|
||
| def apply( | ||
| self, | ||
| release: 'iocage.lib.Release.ReleaseGenerator' |
There was a problem hiding this comment.
importing iocage.lib.Release into this file would be too much?
| self, | ||
| release: 'iocage.lib.Release.ReleaseGenerator' | ||
| ) -> None: | ||
|
|
||
| self.logger.warn( |
There was a problem hiding this comment.
logger is still not part of this class
gronke
force-pushed
the
chore/storage-typing
branch
2 times, most recently
from
845ac9c to
d3e443c
Compare
gronke
force-pushed
the
chore/storage-typing
branch
from
d3e443c to
c10ea60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#155 points out missing type interfaces in Storage classes.