Failing test for glslify #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Edit: Hold on. I have an error. I'll reopen this when it definitely works in webpack@1 and definitely does not work in webpack@2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #7, which didn't work for me since it breaks existing behavior.
This PR adds a failing test using glslify, which is perhaps the common failure point. I've upgraded to webpack 3.4.0 (whose breaking changes I think aren't so relevant for this relative to webpack 2.*).
I haven't yet managed to figure out exactly the right solution, but I thought I'd just submit this right away for the sake of reproducibility.