Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5 (error occurring with webpack2)
Problem
I was having the same type of errors when trying to set up this loader with webpack2 (i.e.
tr.on is not a function
). I was just trying to hook up my shaders to run throughglslify
.Direct Solution
It seems that webpack 2 goes ahead and takes care of a lot of the loading/sequencing behind the scenes, so we get strings for the
transforms
/tr
on line 64 instead of Buffers(?).Best Solution = ?
@hughsk Perhaps you can let me know if the fix I came up with is actually a good idea. I'm fairly new to webpack/browserify/glslify and I'm not sure what I might be breaking with this "fix". But perhaps this might help you identify the right solution faster.
This "fix" unblocks my development locally for now, but my usage is very simple with default options.