update es-private-fields to master #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferentText Retain the version information of script infos when they are deleted
…onstatement expose createExpressionStatement and updateExpressionStatement
Handle multiple output .d.ts files changedness correctly
…umMember_all Combine code-fix-all for missing class member and missing enum member
Consolidate overloads in constructors for Map, Set, WeakMap, and WeakSet
…pIArdlyKnowSignatureHelp
.d.ts files don't have outputs
…_all_dedup fixAddMissingMember: Improve deduplication in code-fix-all
…ck20180702 Use `addRelatedInfo`.
* More thoroughly test navigateTo * Fix microsoft#25233 and microsoft#25237 * Update API (microsoft#24966)
…pIArdlyKnowSignatureHelp Trigger characters in signature help
… bug/25667-getmodifiedtime-has-wrong-return-type
* Revert "Revert "Explicitly typed special assignments are context sensitive (microsoft#25619)"" This reverts commit 16676f2. * Revert "Revert "Explicitly typed prototype assignments are context sensitive (microsoft#25688)"" This reverts commit ff8c30d. * Initial, wasteful, solution It burns a check flags. Probably necessary, but perhaps not. I haven't accepted baselines, but they are a bit questionable. I'm not sure the synthetic type is right, because I expected to see { "exports": typeof import("x") } but instead see { "x": typeof import("x") }. * Update some baselines * module.exports= always uses lhs type Conflicts between exports property assignments and exports assignments should get a union type instead of an error. * Fix lint and accept good user baselines * Add tests based on user tests. These currently fail. * Fix all but 1 of user test bugs found by typing module.exports Still quite messy and full of notes * Follow merged symbols+allow any object type This allows exports like `module.exports = new EE` to have properties added to them. Still messy, but I'm going to run user tests and look for regressions. * Update improved user baselines * Fix infinite recursion when checking module.exports * Fix bogus use-before-def error getExportSymbolOfValueSymbolIfExported should always merge its returned symbol, whether it's symbol.exportSymbol or just symbol. * Update user test baselines * Cleanup * More small cleanup * Bind `module` of `module.exports` as a special symbol Previously it was also special, but created during name resolution in the checker. It made sense when there was only one special symbol for all files, but now there is one `module` symbol per file.
Fix generic rest types
…iedtime-has-wrong-return-type 25667 - getModifiedTime has wrong return type
… instance/static member ..." (microsoft#25847)
* findAllReferences/rename: Search in all open projects * Avoid needing a dummy location when location is unused * Remove Program#getDeclarationEmitPath * Only iterate over enabled projects
…5868) * Split getWidenedTypeFromJSSpecialPropertyDeclaration 1. Handle this-property assignments 2. Handle other special property assignment I have only started simplifying [2]. * Split into two passes 1. Look for jsdoc 2. Look for type of initializers Both can be broken into their own functions. * Break into two functions * Move back to original function and single loop Then, convert the 2 extracted functions to reduce-style functions that take state and return the updated state. * Cleanup suggestions from review
Add `.mailmap` and `Test-results.xml` to .npmignore
…eate a specifier with (microsoft#25850) * Inspect all possible specifier paths when looking for the best one * Add missing secondary option from test
…25838) * Call toPath on sourceRoot to ensure it is always absolute * Leave canonicalization to avoid a Path/string union
Report a semantic error for an arrow function with a "this" parameter.
…icrosoft#25902) * Fix microsoft#25820 - handle redirected files when comparing paths * Update test to do case check
…oder when querying program (microsoft#25908) * Check if the file returned by the program actually refers to the same file as we intend * Simplify
…ents Retain synthetic comments on exports.
kpfleming
approved these changes
Jul 25, 2018
|
This attempt to update the branch isn't going to work, so we'll try another path. |
prakashtinate
pushed a commit
to prakashtinate/TypeScript
that referenced
this pull request
Sep 26, 2019
…20190801-nonNullableCallSignaturesTreeWalk 🤖 User test baselines have changed for nonNullableCallSignaturesTreeWalk
robpalme
pushed a commit
that referenced
this pull request
Jul 1, 2020
* Add deprecated related feature * Add more support * fix navtree * Add identifier check * Add more deprecated * fix crash * fix more crash * fix crash * improve diagnostic * avoid new tag * avoid tags * accept baseline * Check deprecated in binder * fix baseline * fix jsdoc cache * fix incorrect fix * Avoid useless changes * Accept baseline * Add tests * fix perf * fix public api * Adjust deprecated mark on qualifed name * Revolve alias symbol * Use modifier flags insted of symbol props * Fix modifier flag resolve * Make lint happy * Fix crash * fix crash * Add cached utils function * Accept baseline * Add more tests * try pinning octokit again * Avoid tests * Use utils some * Deprecated perf test (#3) * check valueDeclaration only * check without modifierFlags * donot check alias * use cached tag * remove call to jsdoc * use deprecated tag * revert changes * Revert mission changes * use node flags * cache result * cache * avoid modifier flags * Opts * fix jsdoc include modifier * fix tests * fix again * use symbol flag * set @octokit/rest back to latest * fix trailing spacel int Co-authored-by: Nathan Shively-Sanders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.