Retain the version information of script infos when they are deleted #25249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps in having to not restart the versioning, which could potentially have same version but different contents and project could confuse with it
mhegazy
reviewed
Jun 26, 2018
src/server/editorServices.ts
Outdated
| @@ -345,7 +350,7 @@ namespace ts.server { | |||
| /** | |||
| * Container of all known scripts | |||
| */ | |||
| private readonly filenameToScriptInfo = createMap<ScriptInfo>(); | |||
| private readonly filenameToScriptInfo = createMap<ScriptInfoOrVersion>(); | |||
There was a problem hiding this comment.
would it be simpler to have a different map of deleted scripts with their versions instead of a union type? we only need to touch that on add and delete.
mhegazy
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps in having to not restart the versioning,
which could potentially have same version but different contents and project could confuse with it