Skip to content

Combine code-fix-all for missing class member and missing enum member #25335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2018

Noticed in #25182 (CC @Kingwl) that the fix for a missing enum member had a different fix-all description, but the same fixId. This changes it so both add-missing-class-member and add-missing-enum-member fixes use the description "Add all missing members".

@ghost ghost requested a review from mhegazy June 30, 2018 03:04
Copy link
Contributor

@Kingwl Kingwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks😏

@mhegazy mhegazy merged commit 956f9d0 into master Jul 2, 2018
@ghost ghost deleted the codeFixAddMissingEnumMember_all branch July 2, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants