[blocked by discussion in Microsoft/TypeScript repo] Fix property initializers with block scoped bindings #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix microsoft#27864 Signed-off-by: Joseph Watts <[email protected]> * Tests for computed field scope fix Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Closed
|
Similar but distinct from microsoft#28708 we'll re-open against Microsoft/TypeScript repo |
mheiber
changed the title
|
closing because superseded by PR against upstream: microsoft#28708 |
Author
|
@mheiber I think this is distinct from that PR (but depends on a helper function defined in that PR) |
joeywatts
force-pushed
the
computed-property-name-fix
branch
2 times, most recently
from
57a142f to
64a3d96
Compare
mheiber
pushed a commit
to mheiber/TypeScript
that referenced
this pull request
Sep 4, 2019
* Add vscode docker test * Remove PID-log line * Update user baselines (bloomberg#18)
|
@joeywatts closing for now, I think this is out of date. Please re-open if closing in error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft#27864 (comment)