Skip to content

[WIP] private methods again #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 32 commits into
base: esnext-private-instance-fields
Choose a base branch
from
Open

[WIP] private methods again #17

wants to merge 32 commits into from

Conversation

mheiber
Copy link

@mheiber mheiber commented Nov 9, 2018 •
edited
Loading

doesn't actually work yet!

kpfleming and others added 30 commits October 19, 2018 20:47
@kpfleming
Update Travis-CI configuration to build es-private-fields branch
5701839
Parse Private Names
853486f 
and check that private names not used in parameters

Signed-off-by: Max Heiber <[email protected]>
Signed-off-by: Max Heiber <[email protected]>
WIP - Move class property transformation into ESnext transformer
cd46fd8 
Signed-off-by: Joseph Watts <[email protected]>
@joeywatts
WIP
8cd73b6 
- generate statements (not expressions) for decorated class declarations
  which are transformed to class expressions by the ts transformer
- don't generate empty constructor in esnext class transform

Signed-off-by: Joseph Watts <[email protected]>
Fix double emit of static property initializers
99b0bbb 
Signed-off-by: Joseph Watts <[email protected]>
Fix failed conformance tests related to evaluation order, source maps…
0e50dc0 
…, comments, and some other edge cases

Signed-off-by: Joseph Watts <[email protected]>
Don't transform non-async non-generator non-object-rest function body
aa13159 
Signed-off-by: Joseph Watts <[email protected]>
Add comment
0db71b9 
Signed-off-by: Joseph Watts <[email protected]>
Improve comment
25b3ad9 
Signed-off-by: Joseph Watts <[email protected]>
Add/improve comments, fix double visiting constructor
2eebd92 
Signed-off-by: Joseph Watts <[email protected]>
Ensure lexical environment is ended during constructor transformation
3f4d630 
Signed-off-by: Joseph Watts <[email protected]>
@joeywatts
Baseline changes for ESNext Class Property Transformation (#4)
1da18d6 
* Add baselines

* Update baselines

Signed-off-by: Joseph Watts <[email protected]>
Address code review comments
2941edc 
Signed-off-by: Joseph Watts <[email protected]>
Remove unnecessary type assertion
31ac197 
Signed-off-by: Joseph Watts <[email protected]>
Fix broken tests
04aa477 
Signed-off-by: Joseph Watts <[email protected]>
Create property declarations for parameters with property assignments
37ae579 
Signed-off-by: Joseph Watts <[email protected]>
Generate WeakMaps for private named fields
a65d160 
Signed-off-by: Joseph Watts <[email protected]>
Add test case for WeakMap declaration
d16577c 
Signed-off-by: Joseph Watts <[email protected]>
Accept public API changes
6baf417 
Signed-off-by: Joseph Watts <[email protected]>
Transform initializers for private named instance fields
5080172 
Signed-off-by: Joseph Watts <[email protected]>
Add privateNameFieldInitializer test
cdfb649 
Signed-off-by: Joseph Watts <[email protected]>
Transform property access for private named instance fields
e0730a3 
Signed-off-by: Joseph Watts <[email protected]>
Add privateNameFieldAccess test
3341558 
Signed-off-by: Joseph Watts <[email protected]>
Move compound assignment utilities
2451fd9 
Signed-off-by: Joseph Watts <[email protected]>
Transform assignments to private named instance fields
d3fb99d 
Signed-off-by: Joseph Watts <[email protected]>
Add privateNameFieldAssignment test
4fad325 
Signed-off-by: Joseph Watts <[email protected]>
Accept test change
083b4cb 
Signed-off-by: Joseph Watts <[email protected]>
Transform private name bindings in destructuring assignments
f986800 
Signed-off-by: Joseph Watts <[email protected]>
Add privateNameFieldDestructuredBinding test
422a5a7 
Signed-off-by: Joseph Watts <[email protected]>
Transform call expressions on private names to properly bind this
23f9932 
Signed-off-by: Joseph Watts <[email protected]>
@mheiber mheiber changed the title [WIP] start private methods again [WIP] private methods again Nov 9, 2018
@joeywatts joeywatts force-pushed the esnext-private-instance-fields branch from 0c79ea1 to 0b48937 Compare November 21, 2018 01:50
joeywatts added a commit that referenced this pull request Nov 30, 2018
@joeywatts
Fix Computed Property Name Bindings (#17)
bc91292 
* Fix microsoft#27864

Signed-off-by: Joseph Watts <[email protected]>

* Tests for computed field scope fix

Signed-off-by: Joseph Watts <[email protected]>
@joeywatts joeywatts force-pushed the esnext-private-instance-fields branch 3 times, most recently from 2641392 to fa17cdf Compare December 18, 2018 20:20
@mheiber mheiber force-pushed the private-methods branch 3 times, most recently from 79202c7 to 41528f5 Compare December 21, 2018 03:24
@mheiber mheiber force-pushed the private-methods branch 2 times, most recently from 7a5326e to dadc516 Compare December 31, 2018 00:43
@mheiber mheiber force-pushed the private-methods branch 2 times, most recently from f699491 to 1769bb1 Compare January 28, 2019 21:32
@mheiber mheiber force-pushed the private-methods branch 2 times, most recently from edd7359 to 87a79f8 Compare February 11, 2019 21:09
@mheiber mheiber force-pushed the private-methods branch 3 times, most recently from 94291f1 to e36e3aa Compare March 27, 2019 21:46
@mheiber mheiber force-pushed the private-methods branch 2 times, most recently from d6d188b to 3280e43 Compare April 9, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mheiber @kpfleming @joeywatts