Skip to content

Include missed <cassert> headers #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2021
Merged

Include missed <cassert> headers #57

merged 1 commit into from
Oct 10, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 10, 2021

CI log excerpt from #54:

qml/util.cpp: In function ‘QString QmlUtil::GraphicsApi(QQuickWindow*)’:
qml/util.cpp:31:5: error: ‘assert’ was not declared in this scope
     assert(false);
     ^~~~~~
qml/util.cpp:31:5: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?

promag
promag reviewed Oct 10, 2021
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6fb3246.

@hebasto hebasto merged commit 3300f75 into bitcoin-core:main Oct 10, 2021
@hebasto hebasto deleted the 211010-assert branch October 10, 2021 21:16
jarolrod pushed a commit to jarolrod/gui-qml that referenced this pull request Oct 27, 2021
@fanquake
Squashed 'src/univalue/' changes from 98fadc0909..a44caf65fe
9b49ed6 
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues
135254331e Import fixes for sanitizer reported issues
d5fb86940e refactor: use c++11 range based for loop in checkObject
ff9c379304 refactor: Use nullptr (c++11) instead of NULL
08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support
66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus
808d487292 ci: travis -> cirrus
c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration
4a5b0a1c65 build: Move source entries out to sources.mk
6c7d94b33c build: cleanup wonky gen usage
a222637c6d Merge bitcoin-core#23: Merge changes from jgarzik/univalue@1ae6a23
f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD
1ae6a231a0 Merge pull request bitcoin-core#57 from MarcoFalke/test_fix
92bdd11f0b univalue_write: remove unneeded sstream.h include
ffb621c130 Merge pull request bitcoin-core#56 from drodil/remove_sstream_header
f33acf9fe8 Merge commit '7890db9~' into HEAD
66e0adec4d Remove unnecessary sstream header from univalue.h
88967f6586 Version 1.0.4
1dc113dbef Merge pull request bitcoin-core#50 from luke-jr/pushKV_bool
72392fb227 [tests] test pushKV for boolean values
c23132bcf4 Pushing boolean value to univalue correctly
81faab26a1 Merge pull request bitcoin-core#48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS
b17634ef24 Update URLs to MIT license.
88ab64f6b5 Merge pull request bitcoin-core#46 from jasonbcox/master
35ed96da31 Merge pull request bitcoin-core#44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit
420c226290 Merge pull request bitcoin-core#45 from MarcoFalke/Mf1710-univalue-revert-test

git-subtree-dir: src/univalue
git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
hebasto added a commit to hebasto/gui-qml that referenced this pull request Jun 6, 2025
@hebasto
qml: Include missed <cassert> headers
5a69f96 
Github-Pull: bitcoin-core#57
Rebased-From: 6fb3246
hebasto added a commit to hebasto/gui-qml that referenced this pull request Jun 7, 2025
@hebasto
qml: Include missed <cassert> headers
0cb626d 
Github-Pull: bitcoin-core#57
Rebased-From: 6fb3246
hebasto added a commit to hebasto/gui-qml that referenced this pull request Jun 7, 2025
@hebasto
qml: Include missed <cassert> headers
5b553c7 
Github-Pull: bitcoin-core#57
Rebased-From: 6fb3246
hebasto added a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
@hebasto
qml: Include missed <cassert> headers
3185840 
Github-Pull: bitcoin-core#57
Rebased-From: 6fb3246
hebasto added a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
@hebasto
qml: Include missed <cassert> headers
ee08903 
Github-Pull: bitcoin-core#57
Rebased-From: 6fb3246
hebasto added a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
@hebasto
qml: Include missed <cassert> headers
21d170d 
Github-Pull: bitcoin-core#57
Rebased-From: 6fb3246
johnny9 pushed a commit to johnny9/bitcoin-core-app that referenced this pull request Jul 4, 2025
@hebasto
Merge bitcoin-core/gui-qml#57: Include missed <cassert> headers
d1c6f33 
3d8230f qml: Include missed <cassert> headers (Hennadii Stepanov)

Pull request description:

  CI log [excerpt](https://api.cirrus-ci.com/v1/task/5482291775406080/logs/ci.log) from #54:
  ```
  qml/util.cpp: In function ‘QString QmlUtil::GraphicsApi(QQuickWindow*)’:
  qml/util.cpp:31:5: error: ‘assert’ was not declared in this scope
       assert(false);
       ^~~~~~
  qml/util.cpp:31:5: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
  ```

ACKs for top commit:
  promag:
    utACK 3d8230f.

Tree-SHA512: e1d9968554978a615ba81105ddf78c0fa41773541fe97f6e9b7ba69e84fb174658c10656de5c60bef6eac24cac548e163739101fd482e6703a5f1cfd1bdb9a89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@promag promag promag left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hebasto @promag