Skip to content

ci: Add required Qt Quick dev packages #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2021
Merged

ci: Add required Qt Quick dev packages #54

merged 1 commit into from
Oct 12, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 10, 2021 •
edited
Loading

This PR fixes the following CI tasks:

  • "[previous releases, uses qt5 dev package and some depends packages, DEBUG] [unsigned char] [bionic]"
  • "[no depends, sanitizers: address/leak (ASan + LSan) + undefined (UBSan) + integer] [hirsute]"

@hebasto
Copy link
Member Author

hebasto commented Oct 10, 2021 •
edited
Loading

Rebased d58d757 -> 11b6f11 (pr54.01 -> pr54.02) on top of the merged #52.

@hebasto hebasto mentioned this pull request Oct 10, 2021
Merged
hebasto added a commit that referenced this pull request Oct 10, 2021
@hebasto
Merge #57: Include missed <cassert> headers
3300f75 
6fb3246 qml: Include missed <cassert> headers (Hennadii Stepanov)

Pull request description:

  CI log [excerpt](https://api.cirrus-ci.com/v1/task/5482291775406080/logs/ci.log) from #54:
  ```
  qml/util.cpp: In function ‘QString QmlUtil::GraphicsApi(QQuickWindow*)’:
  qml/util.cpp:31:5: error: ‘assert’ was not declared in this scope
       assert(false);
       ^~~~~~
  qml/util.cpp:31:5: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
  ```

ACKs for top commit:
  promag:
    utACK 6fb3246.

Tree-SHA512: e1d9968554978a615ba81105ddf78c0fa41773541fe97f6e9b7ba69e84fb174658c10656de5c60bef6eac24cac548e163739101fd482e6703a5f1cfd1bdb9a89
@hebasto
Copy link
Member Author

hebasto commented Oct 10, 2021

Rebased 11b6f11 -> 65ad0c1 (pr54.02 -> pr54.03).

promag
promag reviewed Oct 12, 2021
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 65ad0c1.

I think later we need more packages in order to run QML tests, like qml-module-qttest, qml-module-qtquick2 and qml-module-qtquick-layouts.

@hebasto hebasto merged commit ec89d70 into bitcoin-core:main Oct 12, 2021
@hebasto hebasto deleted the 211010-ci branch November 16, 2021 13:09
johnny9 pushed a commit to johnny9/gui-qml that referenced this pull request Jul 10, 2025
@hebasto
Merge bitcoin-core#57: Include missed <cassert> headers
d1c6f33 
3d8230f qml: Include missed <cassert> headers (Hennadii Stepanov)

Pull request description:

  CI log [excerpt](https://api.cirrus-ci.com/v1/task/5482291775406080/logs/ci.log) from bitcoin-core#54:
  ```
  qml/util.cpp: In function ‘QString QmlUtil::GraphicsApi(QQuickWindow*)’:
  qml/util.cpp:31:5: error: ‘assert’ was not declared in this scope
       assert(false);
       ^~~~~~
  qml/util.cpp:31:5: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
  ```

ACKs for top commit:
  promag:
    utACK 3d8230f.

Tree-SHA512: e1d9968554978a615ba81105ddf78c0fa41773541fe97f6e9b7ba69e84fb174658c10656de5c60bef6eac24cac548e163739101fd482e6703a5f1cfd1bdb9a89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@promag promag promag left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hebasto @promag