Introduce cross icon #162
Merged
Introduce cross icon #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#162 Rebased-From: 9848f20
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#162 Rebased-From: 9848f20
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#162 Rebased-From: 9848f20
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#162 Rebased-From: 9848f20
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
2171657 qml: introduce cross icon (Jarol Rodriguez) Pull request description: Introduces the cross icon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script. The current production use-case of this icon will be for the [init error x button](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=4204%3A85968) The [cross icon](https://github.com/BitcoinDesign/Bitcoin-Icons/blob/main/optimized/filled/cross.svg) was taken from the [Bitcoin-Icons Repo](https://github.com/BitcoinDesign/Bitcoin-Icons). This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the [optimize-pngs.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py) script. The output of the script is as follows: ``` optimizing cross.png... done summary: +++++++++++++++++ cross.png size diff from: 831 to: 538 old sha256: 594e41b9c71bda69adad516ef480a2b88a233555543a031e469c3526018a5605 new sha256: 15af3b4b9047843b9103f4c778450094eae120b53adf7a7ef79710c231cc7d0b completed. Checksum stable: False. Total reduction: 293 bytes ``` [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/162) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/162) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/162) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/162) ACKs for top commit: hebasto: ACK 2171657, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 99666f6cc0eb81f6b49d09a005917f6224c98692f03c12d889a9edb6a8dd5500a4a51f1f2ecddd8912a701abedaea3108ca140be5c466a3a1bb84e0ecd38b8af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the cross icon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script.
The current production use-case of this icon will be for the init error x button
The cross icon was taken from the Bitcoin-Icons Repo. This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the optimize-pngs.py script. The output of the script is as follows: