Skip to content

Introduce cross icon #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Introduce cross icon #162

merged 1 commit into from
Aug 17, 2022

Conversation

jarolrod
Copy link
Member

Introduces the cross icon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script.

The current production use-case of this icon will be for the init error x button

The cross icon was taken from the Bitcoin-Icons Repo. This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the optimize-pngs.py script. The output of the script is as follows:

optimizing cross.png... done
summary:
+++++++++++++++++
cross.png
  size diff from: 831 to: 538
  old sha256: 594e41b9c71bda69adad516ef480a2b88a233555543a031e469c3526018a5605
  new sha256: 15af3b4b9047843b9103f4c778450094eae120b53adf7a7ef79710c231cc7d0b

completed. Checksum stable: False. Total reduction: 293 bytes

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9848f20, I have reviewed the code and it looks OK, I agree it can be merged.

@hebasto hebasto merged commit b988de2 into bitcoin-core:main Aug 17, 2022
@jarolrod jarolrod deleted the cross-icon branch August 21, 2022 19:46
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants