Skip to content

Refactor Init error window to fit to design spec #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Aug 16, 2022

Refactors the init error window to fit to the design spec: init error window design spec

master PR
Screen Shot 2022-08-15 at 10 18 07 PM Screen Shot 2023-01-16 at 1 53 50 AM

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

closes #130

@jarolrod
Copy link
Member Author

Should be noted that it seems the design calls for a version of inter thats bold instead of semi-bold

@GBKS
Copy link
Contributor

GBKS commented Aug 16, 2022

Looking at the screenshot, the body text doesn't seem quite right yet (font and font size).

@jarolrod jarolrod force-pushed the init-error-window branch 2 times, most recently from 401c51b to 6375791 Compare August 16, 2022 15:53
@jarolrod
Copy link
Member Author

updated from 9862f87 to 6375791

changes: rebased over changes on dependent PR's

@jarolrod
Copy link
Member Author

Updated from 6375791 to 989c49b

changes: fixed font issue, thanks @GBKS for spotting that!

@hebasto hebasto added the UX Designers' opinions are required label Aug 17, 2022
@hebasto
Copy link
Member

hebasto commented Aug 17, 2022

Based on #162 and #162

:)

Anyway, could be rebased.

@jarolrod jarolrod marked this pull request as draft August 17, 2022 17:57
@jarolrod
Copy link
Member Author

setting as draft until design is settled

@jarolrod
Copy link
Member Author

Updated from 989c49b to 2d427d9

changes: rebased over main

@jarolrod jarolrod marked this pull request as ready for review August 18, 2022 00:41
@jarolrod jarolrod changed the title Refactor Init error window to fit to design spec Refactor Init error window to fit to design spec (1/4) Aug 18, 2022
@jarolrod
Copy link
Member Author

updated from from 2d427d9 to 88d9beb

changes: remove irrelevant color definition in dummy rectangle

@jarolrod jarolrod changed the title Refactor Init error window to fit to design spec (1/4) Refactor Init error window to fit to design spec Aug 25, 2022
@jarolrod
Copy link
Member Author

updated from 88d9beb to c06c93c

Changes: Adjusted to fit the following design: init-error-window, but not in it's entirety. Follow-ups to complete the design added to PR descirption for anyoe to pick up.

refactor initerror window to adhere to designers specification
@jarolrod
Copy link
Member Author

jarolrod commented Jan 16, 2023

Updated from c06c93c to 86fde6b

changes:

  • rebased over changes on master
  • removed unnecessary image provider from the initerrorwindow
  • updated pr description

Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 86fde6b

Tested by feeding bitcoin-qt an invalid cli command.

Screenshot from 2023-01-19 20-44-25

@hebasto hebasto merged commit 1a71fd4 into bitcoin-core:main Jan 20, 2023
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
refactor initerror window to adhere to designers specification

Github-Pull: bitcoin-core#164
Rebased-From: 86fde6b
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
refactor initerror window to adhere to designers specification

Github-Pull: bitcoin-core#164
Rebased-From: 86fde6b
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
refactor initerror window to adhere to designers specification

Github-Pull: bitcoin-core#164
Rebased-From: 86fde6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Designers' opinions are required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In consideration of initerrormessage.qml
4 participants