Add Without<Parent> filter to sync_simple_transforms' orphaned entities query
#9518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` to retrieve entities orphaned since the last update. Without this filter, `sync_simple_transforms` will overwrite the `GlobalTransform` of entities that had their parent removed and then replaced in the same frame.
ickshonpe
changed the title
Without<Parent> filter to sync_simple_transforms query for orphaned entitiesWithout<Parent> filter to sync_simple_transforms' orphaned entities query
Member
|
Can you add some regression tests to make sure that this fixes the issues? |
alice-i-cecile
added
C-Bug
Member
|
Definitely a reasonable fix, but I'd also like to see a test or three. |
Contributor
Author
Will do. I'd like to get @nicopap to review as well. I think my understanding of the problem is correct, but want to make sure that there wasn't a good reason for not filtering by |
nicopap
approved these changes
Aug 21, 2023
tim-blackbird
approved these changes
Aug 21, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
joseph-gio
approved these changes
Aug 21, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…tities query (bevyengine#9518) # Objective `sync_simple_transforms` only checks for removed parents and doesn't filter for `Without<Parent>`, so it overwrites the `GlobalTransform` of non-orphan entities that were orphaned and then reparented since the last update. Introduced by bevyengine#7264 ## Solution Filter for `Without<Parent>`. Fixes bevyengine#9517, bevyengine#9492 ## Changelog `sync_simple_transforms`: * Added a `Without<Parent>` filter to the orphaned entities query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
sync_simple_transformsonly checks for removed parents and doesn't filter forWithout<Parent>, so it overwrites theGlobalTransformof non-orphan entities that were orphaned and then reparented since the last update.Introduced by #7264
Solution
Filter for
Without<Parent>.Fixes #9517, #9492
Changelog
sync_simple_transforms:Without<Parent>filter to the orphaned entities query.