[Merged by Bors] - Updated docs for List Trait in bevy_reflect
#6872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Docs
MrGVSV
approved these changes
Dec 6, 2022
james7132
approved these changes
Dec 7, 2022
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Dec 7, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
# Objective Fixes #6866. ## Solution Docs now should describe what the _front_, _first_, _back_, and _last_ elements are for an implementor of the `bevy::reflect::list::List` Trait. Further, the docs should describe how `bevy::reflect::list::List::push` and `bevy::reflect::list::List::pop` should act on these elements. Co-authored-by: Linus Käll <[email protected]>
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
List Trait in bevy_reflectList Trait in bevy_reflect
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective Fixes bevyengine#6866. ## Solution Docs now should describe what the _front_, _first_, _back_, and _last_ elements are for an implementor of the `bevy::reflect::list::List` Trait. Further, the docs should describe how `bevy::reflect::list::List::push` and `bevy::reflect::list::List::pop` should act on these elements. Co-authored-by: Linus Käll <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#6866. ## Solution Docs now should describe what the _front_, _first_, _back_, and _last_ elements are for an implementor of the `bevy::reflect::list::List` Trait. Further, the docs should describe how `bevy::reflect::list::List::push` and `bevy::reflect::list::List::pop` should act on these elements. Co-authored-by: Linus Käll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #6866.
Solution
Docs now should describe what the front, first, back, and last elements are for an implementor of the
bevy::reflect::list::ListTrait. Further, the docs should describe howbevy::reflect::list::List::pushandbevy::reflect::list::List::popshould act on these elements.