Skip to content

Conversation

@james7132
Copy link
Member

Objective

#6461 introduced lto = true as a profile setting for release builds. This is causing the run-examples CI task to timeout.

Solution

Remove it.

@james7132 james7132 added the A-Build-System Related to build systems or continuous integration label Nov 5, 2022
@rparrett rparrett added the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Nov 5, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 5, 2022
bors bot pushed a commit that referenced this pull request Nov 5, 2022
# Objective
#6461 introduced `lto = true` as a profile setting for release builds. This is causing the  `run-examples` CI task to timeout.

## Solution
Remove it.
@bors
Copy link
Contributor

bors bot commented Nov 5, 2022

Build failed:

@alice-i-cecile
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Nov 5, 2022
# Objective
#6461 introduced `lto = true` as a profile setting for release builds. This is causing the  `run-examples` CI task to timeout.

## Solution
Remove it.
@bors bors bot changed the title Remove LTO [Merged by Bors] - Remove LTO Nov 5, 2022
@bors bors bot closed this Nov 5, 2022
@james7132 james7132 deleted the remove-lto branch November 18, 2022 04:18
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective
bevyengine#6461 introduced `lto = true` as a profile setting for release builds. This is causing the  `run-examples` CI task to timeout.

## Solution
Remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Build-System Related to build systems or continuous integration P-Critical This must be fixed immediately or contributors or users will be severely impacted S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants