Skip to content

[Merged by Bors] - Switch render order to 2d-on-top-of-3d #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Switch render order to 2d-on-top-of-3d #4467

wants to merge 1 commit into from

Conversation

geckoxx
Copy link
Contributor

@geckoxx geckoxx commented Apr 13, 2022

Because #3552 got merged only switching the render order is left to fix #3902

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 13, 2022
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Apr 13, 2022
IceSentry
IceSentry approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this count as a breaking change?

@tim-blackbird
Copy link
Contributor

This pr restores behavior from 0.5, and according to the linked issue, rendering 2D and 3D together didn't work at all in 0.6.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it P-Regression Functionality that used to work but no longer does. Add a test for this! labels Apr 13, 2022
@cart
Copy link
Member

cart commented Apr 13, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 13, 2022
@geckoxx
Switch render order to 2d-on-top-of-3d (#4467)
621f396 
Because #3552 got merged only switching the render order is left to fix #3902
@bors
Copy link
Contributor

bors bot commented Apr 13, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Switch render order to 2d-on-top-of-3d [Merged by Bors] - Switch render order to 2d-on-top-of-3d Apr 13, 2022
@bors bors bot closed this Apr 13, 2022
@cart cart mentioned this pull request Apr 13, 2022
Closed
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@geckoxx @aevyrie
Switch render order to 2d-on-top-of-3d (bevyengine#4467)
312a7a7 
Because bevyengine#3552 got merged only switching the render order is left to fix bevyengine#3902
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@geckoxx @ItsDoot
Switch render order to 2d-on-top-of-3d (bevyengine#4467)
403634c 
Because bevyengine#3552 got merged only switching the render order is left to fix bevyengine#3902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@IceSentry IceSentry IceSentry approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issues rendering sprites and 3D models in 0.6 at the same time

5 participants

@geckoxx @tim-blackbird @cart @alice-i-cecile @IceSentry